Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix failing workflow: upgrade linter actions #364

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

leecalcote
Copy link
Member

@leecalcote leecalcote commented Nov 19, 2023

Notes for Reviewers

This PR fixes the lint.yaml workflow, which has been failing. This PR eliminates the node12 error message seen while using older version of the Actions. The pre-existing issue with eslint not being available persists, though:

Run yarn lint && yarn format:check && yarn lint-staged

Oops! Something went wrong! :(

ESLint: 8.50.0

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".

(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/home/runner/work/sistent/sistent/apps/design-system".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install @typescript-eslint/eslint-plugin@latest --save-dev

The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in "apps/design-system/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Error: Process completed with exit code 2.
  • Yes, I signed my commits.

@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Nov 19, 2023
Signed-off-by: leecalcote <[email protected]>
@leecalcote leecalcote requested a review from a team November 19, 2023 21:42
@leecalcote leecalcote merged commit e151d9f into master Nov 19, 2023
5 of 6 checks passed
@leecalcote leecalcote deleted the leecalcote/ci/linter-workflow branch November 19, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Development

Successfully merging this pull request may close these issues.

1 participant