Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svg] Add jest for testing framework and revised three icons into its own dir #34

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

nebula-aac
Copy link
Contributor

@nebula-aac nebula-aac commented Aug 25, 2023

Added

  • jest framework, react testing library
  • revised bus, circle, and application into its own directory

Notes for Reviewers
This PR refers to #33 and and a continuing effort for #12

Three icons have been modified to be in its own directory.

  • Application
  • Bus
  • Circle

Application has three icons, one outlined, one filled with default color, and one with keppel colors.

Added constants instead of hardcoding them.

Bus only has one filled icon with one default color

Circle has partial outlined and filled, but outlined is not fully outlined..

Added another script for coverage using jest

Created __testing__ directory to house the test files

Signed commits

  • Yes, I signed my commits.

@nebula-aac nebula-aac mentioned this pull request Aug 25, 2023
@nebula-aac nebula-aac changed the title [svg] Add jest for testing framework [svg] Add jest for testing framework and revised three icons into its own dir Aug 25, 2023
@nebula-aac nebula-aac merged commit 02e216f into layer5io:master Aug 25, 2023
1 check passed
@aabidsofi19
Copy link
Contributor

aabidsofi19 commented Aug 25, 2023

looks great. i will take the issue of creating a universal test for all icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants