Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty file build failure #242

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

coder12git
Copy link
Member

Notes for Reviewers

This PR fixes #235

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added area/docs Improvements or additions to documentation area/site labels Nov 7, 2023
Copy link
Contributor

@aabidsofi19 aabidsofi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have these empty components

@aabidsofi19 aabidsofi19 merged commit 3abeead into layer5io:master Nov 7, 2023
5 of 6 checks passed
@nebula-aac
Copy link
Contributor

nebula-aac commented Nov 7, 2023

Can we make sure to tag the right open issues, this will make CHANGELOG generate the correct outputs as we do more commits.

Also, when it comes to creating commits, specify which is this for, as most of the commits are done with site directory, this will also help with the CHANGELOG generation too, so we know which ones were specific to site, not the root/core workspace

Also, tagging the open issue within the commits, help to close tickets when they're done. If we're using commitizen properly, this should be done for already when you go through the prompts.

@nebula-aac nebula-aac linked an issue Nov 7, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation area/site
Development

Successfully merging this pull request may close these issues.

[ site]: Create component placeholders for several pages in site Fixing Site build failure
3 participants