chore: makefile and gitignore enhancements #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: leecalcote <[email protected]>
nebula-aac
reviewed
Oct 30, 2023
| !.yarn/versions |
There was a problem hiding this comment.
Thanks for bringing this up.
Yarn 3 and up have recommended .gitignore files to ignore where we can use Zero Installs or not.
Given that Yarn 4 is relatively new, and they support PnP, which is a faster way with a flat file of the dependencies, instead of node_modules, I want to point this out because there may be issues in the future if we were to upgrade Yarn 3 to 4
nebula-aac
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: leecalcote [email protected]
Notes for Reviewers
Signed commits