Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add lint workflow #179

Merged
merged 7 commits into from
Nov 17, 2023
Merged

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Oct 25, 2023

Notes for Reviewers

This PR fixes #37

  • Add lint workflow
  • Revise errorboundary to follow eslint rules for typescript
  • fix more lint checks
  • Improvise in readme

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Oct 25, 2023
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@leecalcote
Copy link
Member

@sudhanshutech you can add this to the Meshery CI build and release agenda to ensure it moves forward.

@nebula-aac
Copy link
Contributor

@sudhanshutech can you update your forked to include the latest from the other PR on ErrorBoundary, it is copied and pasted, but I would like to have some of the bug fixes to be separate for clarity.

…o add/lint/workflow

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@nebula-aac nebula-aac merged commit 3727b2c into layer5io:master Nov 17, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Development

Successfully merging this pull request may close these issues.

[CI] Setup linting workflow
3 participants