Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import build error while using sistent #176

Closed

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Oct 24, 2023

Notes for Reviewers

This PR fixes #173

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@aabidsofi19
Copy link
Contributor

@sudhanshutech what was the issue here

@sudhanshutech
Copy link
Member Author

sudhanshutech commented Oct 24, 2023

@sudhanshutech what was the issue here

the issue is when we trying to use our sistent components in any place we are getting build error failure, which is being mentioned : https://github.com/layer5io/meshery-cloud/pull/1614
This is somewhere we are not correctly exporting the mui-datatables

@leecalcote
Copy link
Member

@sudhanshutech does this fix work?

@nebula-aac
Copy link
Contributor

closing PR as the previous issue is not the same anymore

@nebula-aac nebula-aac closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[components] Revise mui-datatables export
4 participants