Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor data-table config #171

Closed
wants to merge 1 commit into from
Closed

Refactor data-table config #171

wants to merge 1 commit into from

Conversation

sudhanshutech
Copy link
Member

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@sudhanshutech
fix(build): refactor datatable
2ef7cb6 
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@sudhanshutech
Copy link
Member Author

@nebula-aac i am not sure that this will fix build error when using system components or not

We are getting this build error when using either in meshery or cloud

Failed to compile.
./node_modules/@layer5/sistent-components/dist/index.mjs
Attempted import error: 'MUIDataTable' is not exported from 'mui-datatables' (imported as 'tr').

@nebula-aac
Copy link
Contributor

I haven't worked on this issue yet, bear with me,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebula-aac nebula-aac Awaiting requested review from nebula-aac

Assignees
No one assigned
Labels
component/components
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudhanshutech @nebula-aac