Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on
do not merge
, as I am investigating why Storybook isn't building.Before, I had issues with the external modules to be built through Vite, so that this does not cause packages conflict in the Storybook build and dev environments.
This was temporarily resolved by adding them as peer dependencies and optional, so that I don't require you to have them in your current repo.
However the issue popped up again after adding
@types/mui-datatables
as this package relies on a different@emotion/react
version.Have different
@emotion/react
versions can cause issues in running a React app.Notes for Reviewers
This PR fixes #156
Here are some references for the attempt on the changes I've made to resolve this.
Signed commits