Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct external modules #157

Closed
wants to merge 2 commits into from
Closed

fix: Correct external modules #157

wants to merge 2 commits into from

Conversation

nebula-aac
Copy link
Contributor

@nebula-aac nebula-aac commented Oct 10, 2023

This PR is on do not merge, as I am investigating why Storybook isn't building.

Before, I had issues with the external modules to be built through Vite, so that this does not cause packages conflict in the Storybook build and dev environments.

This was temporarily resolved by adding them as peer dependencies and optional, so that I don't require you to have them in your current repo.

However the issue popped up again after adding @types/mui-datatables as this package relies on a different @emotion/react version.

Have different @emotion/react versions can cause issues in running a React app.

Notes for Reviewers

This PR fixes #156

Here are some references for the attempt on the changes I've made to resolve this.

Signed commits

  • Yes, I signed my commits.

@nebula-aac nebula-aac added kind/bug Something isn't working pr/do-not-merge PRs not ready to be merged priority/high High priority issue labels Oct 10, 2023
@nebula-aac nebula-aac self-assigned this Oct 10, 2023
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac
Copy link
Contributor Author

closing, may not need this now

@nebula-aac nebula-aac closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/components component/icons kind/bug Something isn't working pr/do-not-merge PRs not ready to be merged priority/high High priority issue
Development

Successfully merging this pull request may close these issues.

[design-system] Failed to start Storybook
1 participant