Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon]: Add CatalogIcon from Layer5 brand page #632

Closed
dottharun opened this issue May 29, 2024 · 8 comments · Fixed by #641
Closed

[Icon]: Add CatalogIcon from Layer5 brand page #632

dottharun opened this issue May 29, 2024 · 8 comments · Fixed by #641
Labels
component/icons kind/enhancement Improvement in current feature

Comments

@dottharun
Copy link
Contributor

dottharun commented May 29, 2024

Current Behavior

  • There is no existing implementation for CatalogIcon from brand page in sistent

Expected Behavior

  • Add CatalogIcon into sistent, exported ready to use with color parameters.

Contributor Guides and Resources

@dottharun dottharun added the kind/bug Something isn't working label May 29, 2024
@dottharun dottharun changed the title [Icon]: [Icon]: Add CatalogIcon from Layer5 brand page May 29, 2024
@26vanshika
Copy link

Hey I wanna work on this issue but could you specify what type of Catalogicon are you looking for

@dottharun
Copy link
Contributor Author

@26vanshika Thanks for showing interest in this issue,

Feel free to reach out if you need any assistance!

@26vanshika
Copy link

Yeah I have set it up and have also explored other issues, if you could just guide me what type of Catalogico are you looking for primarily

@dottharun
Copy link
Contributor Author

Yes, the brand page mentioned above has the assets you need. For the default fill colors, you can use Keppel and Charcoal as shown in the first example.

@26vanshika
Copy link

26vanshika commented May 31, 2024

Okay I will try my best

@26vanshika
Copy link

Hey @dottharun, just a doubt the catalog icon should look like just like the one in meshery right?
Screenshot 2024-06-01 at 6 11 58 PM

@dottharun
Copy link
Contributor Author

@26vanshika Not sure which one you are referring to, but it's in the Catalog section of the brand page. Please use those assets.

  • Also, look at the other Icon Components in the codebase to get an idea of the parameters for the SVG.

@dottharun
Copy link
Contributor Author

Sorry @26vanshika, This issue is blocking other issues in Meshery, please look at other good first issues in Meshery for contributing.

@leecalcote leecalcote added kind/enhancement Improvement in current feature component/icons and removed kind/bug Something isn't working labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/icons kind/enhancement Improvement in current feature
Development

Successfully merging a pull request may close this issue.

3 participants