Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated all issue templates #26

Merged
merged 12 commits into from
Jul 22, 2023
Merged

Updated all issue templates #26

merged 12 commits into from
Jul 22, 2023

Conversation

sankhadip-roy
Copy link
Contributor

Description
Updated all issue templates with the contributing resources mentioned in Layer5.io's issue_templates
This PR fixes #24

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@sankhadip-roy
Update bug_report.md
1a0cebc 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update documentation.md
6f1807c 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update feature_request.md
03988f9 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update question.md
9bb7c66 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update bug_report.md
d658b4c 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update documentation.md
77d2efd 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update feature_request.md
81dc9db 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update question.md
14858b5 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy sankhadip-roy mentioned this pull request Jul 19, 2023
Closed
@thisiskaransgit thisiskaransgit self-requested a review July 19, 2023 13:04
thisiskaransgit
thisiskaransgit reviewed Jul 20, 2023
View reviewed changes
Copy link

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sankhadip-roy, please incorporate the same changes that I suggested at layer5io/meshery-smi-conformance-action#47

@sankhadip-roy
Update bug_report.md
fc369ea 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update documentation.md
184f685 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update feature_request.md
ed6b5d8 
Signed-off-by: Sankhadip Roy <[email protected]>
@sankhadip-roy
Update question.md
b713bac 
Signed-off-by: Sankhadip Roy <[email protected]>
leecalcote
leecalcote approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great. I don’t see any mishaps in their refactoring.

@leecalcote leecalcote merged commit d3d0745 into layer5io:master Jul 22, 2023
1 check passed
@welcome
Copy link

welcome bot commented Jul 22, 2023

Thanks for your contribution to the Layer5 community! 🎉
Congrats!
        ⭐ Please leave a star on the project. 😄

@leecalcote
Copy link
Member

Thanks, @sankhadip-roy!

@leecalcote
Copy link
Member

@sankhadip-roy, it looks like we have a bug in the welcome config yaml - in case you’re interested in working on it.

@sankhadip-roy
Copy link
Contributor Author

sankhadip-roy commented Jul 22, 2023 •
edited
Loading

@sankhadip-roy, it looks like we have a bug in the welcome config yaml - in case you’re interested in working on it.
Yes absolutely, @leecalcote
Are you talking about the congrats image not showing in the welcome bot's comment ?
If that is the case:

image

I think here the link of the png should be
from this: https://raw.githubusercontent.com/layer5io/meshery/master/.github/welcome/Layer5-celebration.png
to this: https://raw.githubusercontent.com/layer5io/meet/master/.github/welcome/Layer5-celebration.png

If I am right should I first create an issue or just create a pull request?

@leecalcote
Copy link
Member

You're right. Directly to PR will work.

@sankhadip-roy sankhadip-roy mentioned this pull request Jul 23, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisiskaransgit thisiskaransgit thisiskaransgit left review comments

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue Template Updates for Figma link 
3 participants
@sankhadip-roy @leecalcote @thisiskaransgit