chore: add client-side validation for email and picture url fields #5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Vishal <[email protected]>
|
🚀 Preview for commit fbbebe7 at: https://66d463d25429312a1edc6549--layer5.netlify.app |
Signed-off-by: Vivek Vishal <[email protected]>
|
🚀 Preview for commit 3c974b5 at: https://66d469aab15368323b37f867--layer5.netlify.app |
leecalcote
reviewed
Sep 1, 2024
|
|
||
| if (!value) { | ||
| error = "Required"; | ||
| } else if (!/^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}$/.test(value)) { |
There was a problem hiding this comment.
Is this the same regex used by the other site forms?
leecalcote
reviewed
Sep 1, 2024
leecalcote
reviewed
Sep 1, 2024
| const allowedImageExtensions = ["jpg", "jpeg", "png", "webp", "svg"]; | ||
| const extension = value.split(".").pop().toLowerCase(); | ||
| if (!allowedImageExtensions.includes(extension)) { | ||
| error = "URL must point to an image file (jpg, jpeg, png, svg or webp)."; |
leecalcote
reviewed
Sep 1, 2024
Co-authored-by: Lee Calcote <[email protected]> Signed-off-by: Vivek Vishal <[email protected]>
Co-authored-by: Lee Calcote <[email protected]> Signed-off-by: Vivek Vishal <[email protected]>
vishalvivekm
commented
Sep 1, 2024
vishalvivekm
commented
Sep 1, 2024
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
|
🚀 Preview for commit 95596dd at: https://66d47095498964065614936e--layer5.netlify.app |
sudhanshutech
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5855
Notes for Reviewers
Signed commits