Updated Repository Overview to mark meshery-smi-conformance-action as archived #5833
Conversation
Signed-off-by: Harsh Kumar <[email protected]>
|
🚀 Preview for commit acacf32 at: https://66c59d9068e154fb6a036ed4--layer5.netlify.app |
| @@ -208,7 +208,7 @@ const Repository = () => { | |||
| </tr> | |||
| </thead> | |||
| {backendProject.subdata.map((subdata) => { | |||
| const { project,image,language,description,repository,link,maintainers_name } = subdata; | |||
| const { project,image,language,description,repository,link,maintainers_name,accessRequired } = subdata; | |||
There was a problem hiding this comment.
@H-A-R-S-H-K, why these changes?
There was a problem hiding this comment.
@Ashparshp In the frontend projects subdata this type of code was followed so i thought to make it same for backend.
There was a problem hiding this comment.
is this was the ask @H-A-R-S-H-K ?
There was a problem hiding this comment.
@sudhanshutech well we have to show the status of SMI Conformance repo as archived. To achieve that I added a key "accessRequired" with value as "*archived" in the backend projects subdata and added a div to display that "*archived".
was this not the ask ?
| @@ -236,6 +236,7 @@ const Repository = () => { | |||
| > | |||
| <img className="github-icon" src={github} alt="github-icon" /> | |||
| </a> | |||
| <div className="accessRequired"> { accessRequired != "" ? accessRequired : ""}</div> | |||
There was a problem hiding this comment.
@H-A-R-S-H-K explain this?
There was a problem hiding this comment.
@sudhanshutech the reason why I made such changes is because the frontend projects subdata follows this type of code to display status of frontend projects such as "*program participation required" on https://layer5.io/community/handbook/repository-overview page.
|
@H-A-R-S-H-K Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
|
@H-A-R-S-H-K, You were unavailble in last meeting? |
There was a problem hiding this comment.
Please change the ask only, Also, please attend the meeting to get feedback on the timing.
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.
|
@H-A-R-S-H-K Alternatively, we could rename |
Description
This PR fixes #5832
Screenshots
Notes for Reviewers
Signed commits