Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the UI of ebpf and other svg's for better visibility in dark mode #5819

Closed
wants to merge 7 commits into from

Conversation

Suswetha6
Copy link

Description

This PR fixes #5070

Notes for Reviewers
I've added a new property in the theme objects in themeStyles.js and updated the css of svg in meshmap section.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 15, 2024

🚀 Preview for commit a486635 at: https://66bda7570d0bf57b1954d8ab--layer5.netlify.app

@narasimha-1511
Copy link
Member

Hey @Suswetha6 please sign the commits using -s , now you need to rebase and squash them

@narasimha-1511
Copy link
Member

narasimha-1511 commented Aug 15, 2024

Screenshot 2024-08-16 at 2 26 54 AM

You should not add the boder box or something kindly change the svg itself which appears better in the dark mode

Copy link
Member

@narasimha-1511 narasimha-1511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly remove these borders and update the svg

@@ -120,6 +120,8 @@ box-shadow: 0px 6px 5px 0px rgb(0 0 0 / 25%);
max-width:5.6rem;
display:block;
margin: 0 auto;
border: 2px solid ${props => props.theme.borderColorWhiteToTransparent};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these borders

CNAME Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suswetha6, why did you remove this file?

@Ashparshp
Copy link
Contributor

@narasimha-1511, do we have a svg for this? and @Suswetha6, please fix the DCO sign-off. If you're unaware, read more about it in the contributing guide.

@Ashparshp
Copy link
Contributor

@Suswetha6, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@Ashparshp
Copy link
Contributor

@Suswetha6, please join. The meeting has started.

@Ashparshp
Copy link
Contributor

@Suswetha6, any luck?

@Ashparshp
Copy link
Contributor

@Suswetha6, checking again?

@Suswetha6
Copy link
Author

Hey @narasimha-1511 , sorry i was not available. I am not sure how to do the DCO sign-off, i will read about it and do it by eod

Signed-off-by: Suswetha6 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 22, 2024

🚀 Preview for commit 0aada74 at: https://66c6e5c9cde1b814330e07c2--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@Suswetha6, any update?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suswetha6 Why is this file deleted ? will you revert this change please ?

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any difference this PR makes to the svgs what we have right now:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you please sound off why are these theme changes are being introduced ? @Suswetha6

@Suswetha6 Suswetha6 closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Dark mode version of eBPF logo on Meshmap Page
5 participants