fix: media Resources not in center issue #5797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Amrutiya <[email protected]>
|
🚀 Preview for commit dd3b72f at: https://66b4b242de61d5f2ae71cc86--layer5.netlify.app |
|
@amitamrutiya Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
Ashparshp
reviewed
Aug 13, 2024
|
I tried it, but since we have already defined properties like border and padding in the |
sudhanshutech
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5787
Fix this issue by creating a parent component, making it a flex container, and centering it horizontally. Previously, we used margin for centering, which was causing the issue.
Signed commits