Fixed issue #5696 : Made the card clickable #5743
Conversation
Signed-off-by: DevMhrn <[email protected]>
|
@Muhammed-Moinuddin , Please review this pr I have made the changes and fixed the issue #5696 |
|
🚀 Preview for commit 04570fe at: https://66a65e5876df8d4d425a2601--layer5.netlify.app |
Let's review this PR in tomorrow's website meeting https://meet.layer5.io/websites |
|
@DevMhrn Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
|
@Muhammed-Moinuddin @Ashparshp , is this pr good to be merged or it needs soomething to added or upgraded , Please let me know happy to improve it if needed . |
|
@DevMhrn Have you joined the slack? |
|
@DevMhrn I couldn't find your name on Slack, so if you haven't joined, please do so. Let's discuss this PR in today's website call. |
|
Now i am in slack , you can text me there if there is something to discuss @Ashparshp |
|
@Muhammed-Moinuddin @Ashparshp I watched the recording of the meeting, thanks for the review of this pr , I will change hover effect same as the other cards , if i am missing any other thing please let me know . |
Signed-off-by: DevMhrn <[email protected]>
|
@Muhammed-Moinuddin @Ashparshp made the changes as suggested in meeting review . If you find everything good in this pr , please consider to merge it . |
|
🚀 Preview for commit 5991a53 at: https://66a90b9759756a427b6c8c0d--layer5.netlify.app |
@DevMhrn due to use of gatsby Link tag, the color of title is changed. KIndly correct it. Title color should not change on hover as well. |
|
@Muhammed-Moinuddin Made the changes as asked , please check it . And please consider to merge it |
|
🚀 Preview for commit 0c4d353 at: https://66aa60fce19c5900a3506bc5--layer5.netlify.app |
|
@Ashparshp @Muhammed-Moinuddin Please review this pr, it's mostly matches to the requirement of the issue and fixes it , after the latest pr i have raised as per asked . |
|
🚀 Preview for commit 8f93e95 at: https://66acfa3664f3fc752f37761e--layer5.netlify.app |
|
@DevMhrn Kindly correct DCO issue and you missed my review comments. Kindly check them as well. |
DevMhrn
force-pushed
the
ddev
branch
2 times, most recently
from
1bb107f
to
5991a53
Compare
|
🚀 Preview for commit 5991a53 at: https://66ad1b6ffe7aada01121835a--layer5.netlify.app |
Signed-off-by: DevMhrn <[email protected]>
|
@Muhammed-Moinuddin please check it . changed it to same as the component card as asked by you , if you want to change the color to green or something like that , then i will change it . And also same feature as component card |
|
🚀 Preview for commit cb12563 at: https://66ad24333cf2b49d53b521f3--layer5.netlify.app |
|
@DevMhrn Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
|
@Ashparshp , I have added the agenda in the meeting minutes |
Signed-off-by: DevMhrn <[email protected]>
|
🚀 Preview for commit 1276765 at: https://66b0d1b164f3fcf4f8380ab8--layer5.netlify.app |
|
@sudhanshutech could you check the updates , in the recent pr i have raised |
Description
This PR fixes #5696
Notes for Reviewers
I have made the card clickable and made some changes in the CSS for enhanced view.
Here is the video:
Watch the video
Screen.Recording.2024-07-28.201221.mp4
Signed commits