[React] Migration to React Version-18 #5732
Conversation
Signed-off-by: Aviral Asthana <[email protected]>
|
Is React 18 required by Gatsby 5? |
|
@vishalvivekm @dottharun @sudhanshutech our focus should be on reviewing, updating, and merging @randychilau's most excellent work in this PR - #4646 |
Signed-off-by: Aviral Asthana <[email protected]>
Yes, React 18 is required for migrating to Gatsby V5. |
|
🚀 Preview for commit 8bc24cf at: https://66a40f0d07f56f50ab6b33d1--layer5.netlify.app |
|
🚀 Preview for commit 8ab7724 at: https://66a413b79f41aa633b2496b1--layer5.netlify.app |
Thank you for confirming. Please verify that this package supports React 18, too - https://github.com/layer5labs/meshery-extensions-packages/tree/master/meshery-design-embed |
Currently, this package doesn't support React-18. |
| @@ -14,7 +14,7 @@ jobs: | |||
|
|
|||
| - name: Install and Build 🔧 | |||
| run: | | |||
| npm install | |||
| npm install --legacy-peer-deps | |||
| @@ -17,7 +17,7 @@ jobs: | |||
|
|
|||
| - name: Install and Build 🔧 | |||
| run: | | |||
| npm install | |||
| npm install --legacy-peer-deps | |||
There was a problem hiding this comment.
I have included this because some packages do not support React 18. Therefore, during the installation process, it will skip those packages.
There was a problem hiding this comment.
It is not permanent change we will revert this when all the packages which currently do not support React - 18 are replaced. It is just to bypass those dependencies. I can build the site successfully after these changes. Also major dependency is Meshery-embed-design package i think when it will be upgraded we can remove this.
|
@Aviral0702 what about those packages those needed to upgrade to support to react18. Have you not upgraded till yet? Checks are failing |
Some packages on upgrading produces graphql errors due to which Graphql Query fails to execute. I am working on it. Checks are failing because when we are trying to upgrade version of React those packages which do not support it are throwing errors leading to failure of installation of v18. |
|
🚀 Preview for commit bd430fc at: https://66a76fc0dca1fe1b59d42a53--layer5.netlify.app |
|
🚀 Preview for commit 9d58fc1 at: https://66ac817f0e9243e7ccef3e96--layer5.netlify.app |
|
🚀 Preview for commit 8e69351 at: https://66adf5b38362b35acd52e31a--layer5.netlify.app |
|
🚀 Preview for commit 6f4899f at: https://66af881a388a07a5084ab0cf--layer5.netlify.app |
|
🚀 Preview for commit f099445 at: https://66b25db94ce5c52f82c973ad--layer5.netlify.app |
|
🚀 Preview for commit b71e4b7 at: https://66c2b4a61f6ae6382a98d979--layer5.netlify.app |
|
🚀 Preview for commit 16ebd53 at: https://66c74c11b3f6bc3a362f6fc2--layer5.netlify.app |
Description
This pull request upgrades the Layer5 website to React 18.
This PR fixes #
Notes for Reviewers
Signed commits