changed the overflow property of the app.style.js file to hidden #5729
Conversation
|
🚀 Preview for commit ceca5ed at: https://66a3b7e224609a0075d3fa00--layer5.netlify.app |
BHAV0207
force-pushed
the
Layer5-Contribution
branch
from
ceca5ed
to
f10f8c7
Compare
Signed-off-by: BHAV0207 <[email protected]>
BHAV0207
force-pushed
the
Layer5-Contribution
branch
from
f10f8c7
to
16c4301
Compare
|
🚀 Preview for commit 16c4301 at: https://66a3c8489bd4590eed255d15--layer5.netlify.app |
|
@BHAV0207 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
| @@ -43,6 +43,7 @@ const GlobalStyle = createGlobalStyle` | |||
| } | |||
|
|
|||
| html{ | |||
| overflow-x: hidden; | |||
There was a problem hiding this comment.
have you tested this all pages and its not having negative effect right?
There was a problem hiding this comment.
yes I have tested all pages , on my side there are no negative effects
|
Hey @sudhanshutech I found one side effect : On this page, the right part of the person's image is hidden due to these changes.
Wait for @Ashparshp confirmation before making any changes. |
|
@amitamrutiya Thanks, but can you please confirm the width for which you are facing this issue? |
Also, I will ask you to recheck as everything seems good on my side. |
|
Any standard mobile screen size around 450px. |
|
Weird, I am facing this issue in Firefox but not in Chrome.🤔 |
|
Thank you @amitamrutiya. But everything looks good on my side. Please recheck from your side and confirm. |
|
Could you please go through the page at layer5.io//cloud-native-management/meshery/operating-cloud-native-infra and check if the issue still exists? It might not be related to this PR. |
|
I am checking on this link https://66a3c8489bd4590eed255d15--layer5.netlify.app/cloud-native-management/meshery/operating-cloud-native-infra (this pr preview url) at firefox.
In chrome everything looks perfect. |
|
By the way not a big issue. I think there is something not going well on my side. No worries :) |
|
The issue you are facing is not related to this PR; (it existed before this PR and persists in Firefox). Thank you so much for your review. Keep it up! |
|
@BHAV0207 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
|
Specifically for the Homepage, what I found out is that just by removing one of the section i.e. (Deploy Faster Together With Confidence). The horizontal scrolling issue is resolved. So I think we just need to solve that section instead of adding it directly for the whole website. |
|
@Muhammed-Moinuddin, we're doing this because many pages in the handbook section have horizontal scrolling issues. By addressing this, we can fix all of them at once instead of solving for each page separately. I hope that's clear! |
|
@sudhanshutech can you please review the changes |
|
@Muhammed-Moinuddin, @hargunkaur286, @amitamrutiya, @BHAV0207, do you have anything to say, or are we good to go with this PR? |
from my side it's good to go. |
This seems fine to me. We can move forward with it. But... I got a small question that if we look another side of the picture, how we are going to find out responsiveness issues created due to any components overflow? This will make us to ignore those issues even they existed due to not making them properly responsive etc... |
|
LGTM as well.
Unfortunately, we’re stuck with just manual testing for now. 😔🔧 |
The horizontal overflow will be hidden for now, but we should identify the root cause of the overflow issue. If anyone has a better solution or is willing to investigate this further, that would be great. If you think this approach might cause problems, feel free to suggest an alternative. Is anyone up for investigating or coming up with a better approach? |
|
@amitamrutiya, do we need automation testing for this? If yes and you're up for this then let me know. |
|
I am not familiar with automation testing for this. |
|
@amitamrutiya, alright! No issues. |
Description
This PR fixes #5721
Notes for Reviewers
In this PR, I explicitly added styling to the html tag which fixes the responsiveness issue for Devices of different screen sizes. The website's has become more responsive and more aligned to the dimensions of the devices.