Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed text content issue #5728

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

aka-bisht
Copy link
Contributor

@aka-bisht aka-bisht commented Jul 26, 2024

Description

This PR fixes #5709

Notes for Reviewers

In this PR, I fixed the syntax and explicitly added JSX tags to the k8s-multi-cluster.mdx file, which resolved the text color issue in dark mode.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 26, 2024

🚀 Preview for commit cf8e2f5 at: https://66a3b00fdab3a51817b19e1c--layer5.netlify.app

@aka-bisht
Copy link
Contributor Author

hey @sudhanshutech can you review this PR I just reworked on this issue.

@leecalcote
Copy link
Member

Thanks, @akaBisht 😄

@l5io
Copy link
Contributor

l5io commented Jul 27, 2024

🚀 Preview for commit 8c138ff at: https://66a4f2cc94ed98183fcd75f7--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jul 28, 2024

🚀 Preview for commit ad3c842 at: https://66a5dcc69bd459dca6255f96--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@akaBisht Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Aug 1, 2024

🚀 Preview for commit 87b0d05 at: https://66aaff26e7b358654f99bb15--layer5.netlify.app

@aka-bisht
Copy link
Contributor Author

hey @sudhanshutech can you review this PR.

@sudhanshutech sudhanshutech merged commit 8a66cae into layer5io:master Aug 5, 2024
5 checks passed
@aka-bisht aka-bisht deleted the text-content-color-fix branch August 6, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Visibility issues on What is Multi-Cluster Kubernetes?
6 participants