Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code section of identity to table format #5691

Closed
wants to merge 1 commit into from

Conversation

mannika763
Copy link
Contributor

@mannika763 mannika763 commented Jul 17, 2024

Description

This PR fixes #5668

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@mannika763
Copy link
Contributor Author

This PR doesn't contain the final changes. I have made changes in the Primitive Category for now. I would like to confirm if this is the right approach, or I would appreciate your guidance on what the approach should be.

Thank you!

@l5io
Copy link
Contributor

l5io commented Jul 17, 2024

🚀 Preview for commit ad43362 at: https://6697f2ccfebba8f53f006db4--layer5.netlify.app

@hargunkaur286
Copy link
Member

Looks good to me! Also, if you would take care of responsiveness and change in the colors of the table in the dark mode

@mannika763
Copy link
Contributor Author

okay, i'll consider all these points also.

@leecalcote
Copy link
Member

Thank you, @mannika763 !

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice @mannika763 . Though there is table in sistent @mannika763 named as responsibledatatablewhich you can use here so you don't have make so many changes and you will also find the readme how to use it: https://github.com/layer5io/sistent/tree/master/src/custom#responsive-data-table-component
You find the examples of it in meshery playground which can be found in meshery repo

@mannika763 mannika763 closed this by deleting the head repository Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Sistent] Move code section of identity to table format
5 participants