Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sistent modal component #5650

Merged
merged 11 commits into from
Jul 13, 2024
Merged

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Jul 8, 2024

Description

This PR fixes #5519

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@github-actions github-actions bot added the area/projects An issue relating to Layer5 initiatives (projects) label Jul 8, 2024
@sudhanshutech sudhanshutech changed the title Add sistent modal component [WIP] Add sistent modal component Jul 8, 2024
@l5io
Copy link
Contributor

l5io commented Jul 8, 2024

🚀 Preview for commit c9bd32f at: https://668ba40161200ef289114fe1--layer5.netlify.app

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@sudhanshutech sudhanshutech changed the title [WIP] Add sistent modal component Add sistent modal component Jul 8, 2024
@l5io
Copy link
Contributor

l5io commented Jul 8, 2024

🚀 Preview for commit 3ea33e0 at: https://668bcb973bde7d0acfeafc53--layer5.netlify.app

Copy link
Member

@hargunkaur286 hargunkaur286 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-10 at 1 16 06 PM opening the modal component redirects to a blank page. Also, the "Modal" component the we import from the sistent package, by default has an overlay property cannot be overwritten and thus, we cannot display the modal inline, as it was given in the figma file: Screenshot 2024-07-10 at 1 20 29 PM

I was trying to make the modal to be pixel perfect which is why i made a custom component for the "overview", "guidance" and the "code" pages, for the sake of displaying them on the screen. The modal imported from the sistent package has extra padding in the header and footer, and no space between the buttons, and making changes in it wouldn't make any sense.
Screenshot 2024-07-10 at 1 28 23 PM

This is why I got confused, but if this is the approach that we'll be working with, then it looks good to me. Let me know if I can help in any part.

@l5io
Copy link
Contributor

l5io commented Jul 11, 2024

🚀 Preview for commit ae28f0a at: https://668fcdb215bf4d0e4f8f7d20--layer5.netlify.app

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 11, 2024

🚀 Preview for commit 4b957c1 at: https://668fe39fc07f28307f92ae2b--layer5.netlify.app

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 12, 2024

🚀 Preview for commit 8a5dc4e at: https://6691a68c2fc3db59838a057a--layer5.netlify.app

@sudhanshutech sudhanshutech merged commit 5ce5785 into layer5io:master Jul 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects)
Development

Successfully merging this pull request may close these issues.

[Sistent] Implement Modal component page
3 participants