-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sistent modal component #5650
Conversation
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
🚀 Preview for commit c9bd32f at: https://668ba40161200ef289114fe1--layer5.netlify.app |
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
🚀 Preview for commit 3ea33e0 at: https://668bcb973bde7d0acfeafc53--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to make the modal to be pixel perfect which is why i made a custom component for the "overview", "guidance" and the "code" pages, for the sake of displaying them on the screen. The modal imported from the sistent package has extra padding in the header and footer, and no space between the buttons, and making changes in it wouldn't make any sense.
This is why I got confused, but if this is the approach that we'll be working with, then it looks good to me. Let me know if I can help in any part.
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
🚀 Preview for commit ae28f0a at: https://668fcdb215bf4d0e4f8f7d20--layer5.netlify.app |
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
🚀 Preview for commit 4b957c1 at: https://668fe39fc07f28307f92ae2b--layer5.netlify.app |
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
🚀 Preview for commit 8a5dc4e at: https://6691a68c2fc3db59838a057a--layer5.netlify.app |
Description
This PR fixes #5519
Notes for Reviewers
Signed commits