Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Modal Component #5625

Closed
wants to merge 2 commits into from
Closed

Added Modal Component #5625

wants to merge 2 commits into from

Conversation

hargunkaur286
Copy link
Member

@hargunkaur286 hargunkaur286 commented Jul 1, 2024 •
edited
Loading

Description

This PR fixes #5519

Notes for Reviewers
@sudhanshutech Can you please review this?

Signed commits

  • Yes, I signed my commits.

@hargunkaur286
added modal page
5745887 
Signed-off-by: Hargun Kaur <[email protected]>
@hargunkaur286
added modal component
52a82f0 
Signed-off-by: Hargun Kaur <[email protected]>
@github-actions github-actions bot added the area/projects An issue relating to Layer5 initiatives (projects) label Jul 1, 2024
@l5io
Copy link
Contributor

l5io commented Jul 1, 2024

🚀 Preview for commit 52a82f0 at: https://66824385f102c1d8bac4e00f--layer5.netlify.app

@Deepak0320Singhal
Copy link
Contributor

@hargunkaur286 Thank you for your contribution.
Let's discuss this on Websites's call. Add this as an agenda item into the meeting minutes.

@sudhanshutech
Copy link
Member

what is the progress @hargunkaur286 ?

@sudhanshutech
Copy link
Member

sudhanshutech commented Jul 4, 2024 •
edited
Loading

@hargunkaur286 what issue you are having when using sistent only modal components? I wonder we should not make here a custom one

@iArchitSharma
Copy link
Contributor

@hargunkaur286 ?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/projects An issue relating to Layer5 initiatives (projects) issue/remind
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sistent] Implement Modal component page
6 participants
@hargunkaur286 @l5io @Deepak0320Singhal @sudhanshutech @iArchitSharma @vishalvivekm