Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding animations to src/section/Home/Playgrougn-home/index.js #5581

Conversation

JonathanKoerber
Copy link

@JonathanKoerber JonathanKoerber commented Jun 13, 2024

Description

This PR fixes #5513

Notes for Reviewers
Added animation using CSS transform. Because the images scroll outside the parent div I had to disable the useInView check.
layer5-animation

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jun 13, 2024

🚀 Preview for commit 8b3db1a at: https://666b623c273aa9ada703b3d6--layer5.netlify.app

@Deepak0320Singhal
Copy link
Contributor

@JonathanKoerber Thank you for your contribution.
Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much of lint changes @JonathanKoerber remove them please. Its become hard to review
and where is styling for animations?

@iArchitSharma
Copy link
Contributor

@JonathanKoerber are u still working on this?

@l5io
Copy link
Contributor

l5io commented Jul 5, 2024

🚀 Preview for commit e6be463 at: https://6687e7ad7b536c5712070e8d--layer5.netlify.app

@JonathanKoerber
Copy link
Author

@sudhanshutech are you meaning the spacing?

@sudhanshutech
Copy link
Member

@sudhanshutech are you meaning the spacing?

what is the meaning of linting😅. Unnecessary line changes

@l5io
Copy link
Contributor

l5io commented Jul 13, 2024

🚀 Preview for commit 9b218b6 at: https://66922564c9f4c8cbfe474b7d--layer5.netlify.app

@sudhanshutech
Copy link
Member

@JonathanKoerber this been already fixed , so lets close this for now . Thanks for jumping in this issue though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Animation] Add animation to "Manage your Cloud Native mess" section on homepage
5 participants