refactor(5448): changes related to SEO #5580
Conversation
Signed-off-by: surajgjadhav <[email protected]>
|
🚀 Preview for commit 1f9a8dc at: https://666b17343d4ad04b66aa68b9--layer5.netlify.app |
Signed-off-by: surajgjadhav <[email protected]>
|
🚀 Preview for commit b00d129 at: https://666b299c3d4ad0632eaa6a25--layer5.netlify.app |
|
@surajgjadhav Thank you for your contribution. |
Signed-off-by: surajgjadhav <[email protected]>
|
Hi @Yashsharma1911 @sudhanshutech , Before Change: After Change: Please note: localhost reports are not accurate but we can take a guess Thanks |
|
🚀 Preview for commit eaa66fb at: https://6676d99b02ce93b6f79bf12b--layer5.netlify.app |
| @@ -92,8 +86,8 @@ const MeshmapHeroSection = () => { | |||
| <p>MeshMap is the world’s only visual designer for Kubernetes and cloud native applications. Design, deploy, and manage your Kubernetes-based, cloud native deployments allowing you to speed up infrastructure configuration.</p> | |||
| </div> | |||
| <div className="hero-image"> | |||
| <img className={imageInView ? "locator-moving" : "locator"} src={isDark ? MeshmapLocatorDark : MeshmapLocatorLight} alt="locator" /> | |||
| <img className={imageInView ? "map map-visible" : "map"} src={isDark ? MeshmapImageBottomDark : MeshmapImageBottomLight} alt="integrations" ref={locatorRef} /> | |||
| <img className={inView ? "locator-moving" : "locator"} src={isDark ? MeshmapLocatorDark : MeshmapLocatorLight} alt="locator" /> | |||
There was a problem hiding this comment.
can you explain this change?
There was a problem hiding this comment.
Here is small refactoring related to state management, based on this observation I have created another ticket refactor other pages: #5589
There was a problem hiding this comment.
This factor is also impacting performance as state gets changed it will re render page and current implementation can lead to infinite loop in some of the edge cases
|
@srujan0404, have you recieved anything about this PR? Or any update to share? |
Description
This PR fixes #5448
Notes for Reviewers
Note: these are the basic changes not complete improvement in SEO score, but can impact the SEO score with some %. But there is scope of improvement in cloud-native-management/meshmap/design page which we can keep on improving as we go.
Signed commits