Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Add Enhanced Integrations #5288

Merged
merged 15 commits into from
Jan 19, 2024

Conversation

theBeginner86
Copy link
Member

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <[email protected]>
@theBeginner86 theBeginner86 changed the title [chore] Add Enhanced Integrations update [chore] Add Enhanced Integrations Jan 15, 2024
Signed-off-by: Pranav Singh <[email protected]>
@vishalvivekm vishalvivekm mentioned this pull request Jan 17, 2024
1 task
Signed-off-by: Pranav Singh <[email protected]>
Signed-off-by: Pranav Singh <[email protected]>
@vishalvivekm
Copy link
Member

Tested it. Thank you @theBeginner86
Just that a comma is missing

current state:

components: [
{
"name": "azure-identity"
"colorIcon": "icons/components/azure-identity/icons/color/azure-identity-color.svg"
"whiteIcon": "icons/components/azure-identity/icons/white/azure-identity-white.svg"
"description": ""
},
{
"name": "azure-identity-binding"
"colorIcon": "icons/components/azure-identity-binding/icons/color/azure-identity-binding-color.svg"
"whiteIcon": "icons/components/azure-identity-binding/icons/white/azure-identity-binding-white.svg"
"description": ""
},
{
"name": "azure-pod-identity-exception"
"colorIcon": "icons/components/azure-pod-identity-exception/icons/color/azure-pod-identity-exception-color.svg"
"whiteIcon": "icons/components/azure-pod-identity-exception/icons/white/azure-pod-identity-exception-white.svg"
"description": ""
}]

desired state:

components: [
{
"name": "azure-assigned-identity",
"colorIcon": "icons/components/azure-assigned-identity/icons/color/azure-assigned-identity-color.svg",
"whiteIcon": "icons/components/azure-assigned-identity/icons/white/azure-assigned-identity-white.svg",
"description": ""
},
{
"name": "azure-identity",
"colorIcon": "icons/components/azure-identity/icons/color/azure-identity-color.svg",
"whiteIcon": "icons/components/azure-identity/icons/white/azure-identity-white.svg",
"description": ""
},
{
"name": "azure-identity-binding",
"colorIcon": "icons/components/azure-identity-binding/icons/color/azure-identity-binding-color.svg",
"whiteIcon": "icons/components/azure-identity-binding/icons/white/azure-identity-binding-white.svg",
"description": "",
},
{
"name": "azure-pod-identity-exception",
"colorIcon": "icons/components/azure-pod-identity-exception/icons/color/azure-pod-identity-exception-color.svg",
"whiteIcon": "icons/components/azure-pod-identity-exception/icons/white/",
"description": ""
}]

@vishalvivekm
Copy link
Member

vishalvivekm commented Jan 17, 2024

[will be updating]
I'm adding notes here:

  • value for howItWorksDetails should be enclosed in " " as it previously was. It's multiline and contains, colon, commas, quotes.
  • as in each integrations' folder, icon has been renamed to -> icons, this has two breaking changes

Signed-off-by: vishalvivekm <[email protected]>
@vishalvivekm vishalvivekm mentioned this pull request Jan 17, 2024
1 task
@vishalvivekm
Copy link
Member

@theBeginner86, Based on this PR and incorporating notes: I tried sending a test PR: #5296 and it's successfully building.

Should I now do those changes to this PR?

  • Basically enclosing howItWorksDetails in quotes helped.

@leecalcote
Copy link
Member

@theBeginner86, Based on this PR and incorporating notes: I tried sending a test PR: #5296 and it's successfully building.

Should I now do those changes to this PR?

  • Basically enclosing howItWorksDetails in quotes helped.

Yes, you can make changes here for testing. Those changes will ultimately need to be propagated into the golang script that generates the pages, though.

@vishalvivekm
Copy link
Member

@theBeginner86, Based on this PR and incorporating notes: I tried sending a test PR: #5296 and it's successfully building.
Should I now do those changes to this PR?

  • Basically enclosing howItWorksDetails in quotes helped.

Yes, you can make changes here for testing. Those changes will ultimately need to be propagated into the golang script that generates the pages, though.

done.

@l5io
Copy link
Contributor

l5io commented Jan 19, 2024

🚀 Preview for commit 61eb182 at: https://65aa7b593d2dcb0b582b07d4--layer5.netlify.app

@theBeginner86
Copy link
Member Author

Thank you @vishalvivekm for your help 🙏

@theBeginner86 theBeginner86 merged commit 0db499b into master Jan 19, 2024
4 checks passed
@theBeginner86 theBeginner86 deleted the theBeginner86/chore/integrations branch January 19, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants