Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] added cursor animation #5217

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

captain-Akshay
Copy link
Contributor

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: captain-Akshay <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 17, 2023

🚀 Preview for commit 6907621 at: https://657ece46c7a0a558f093a4ac--layer5.netlify.app

@ritiksaxena124
Copy link
Contributor

Looks good @captain-Akshay 🔥, Great work, just a small change will you move the cursor only over the image container and not over the whole card because the cursors are hindering the text when they move over the text?

@AbiodunVlad
Copy link
Contributor

The feature really looks great.

@l5io
Copy link
Contributor

l5io commented Dec 18, 2023

🚀 Preview for commit c2f133c at: https://6580bbe8ad30d422718e7703--layer5.netlify.app

@leecalcote
Copy link
Member

Whoa, I didn't see this earlier. So, this is pretty neat. It is also slightly distracting. I wonder what we might do to tame it a little; to have it show in another portion of the screen (down lower in addition to around the second section). I wonder if we can have these be a z-index lower than the section information sits, so that the cursors go behind the information that we're presenting instead of in front of the information.

Signed-off-by: captain-Akshay <[email protected]>
Signed-off-by: captain-Akshay <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 20, 2023

🚀 Preview for commit 9e22a1a at: https://6582910d318f7a3c8bc26dd6--layer5.netlify.app

Copy link
Contributor

@ritiksaxena124 ritiksaxena124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🔥

@leecalcote
Copy link
Member

There's some finesse on display here, @captain-Akshay. Very nice.

@leecalcote leecalcote merged commit 164292b into layer5io:master Dec 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants