Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated debounceTimeout of Blog Search bar #4802

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

iArchitSharma
Copy link
Contributor

@iArchitSharma iArchitSharma commented Aug 29, 2023

Description

This PR fixes #4788

Blog page: https://layer5.io/blog

The initial setting for debounceTimeout was 500ms (0.5 seconds), I propose to increase the debounceTimeout to 5000ms (5 seconds).
This adjustment allows the search functionality to wait for a slightly longer duration before triggering a search request. As a result, users will experience a smoother and more responsive search process, especially when they are typing multiple search terms or navigating between different search inputs.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Aug 29, 2023

🚀 Preview for commit f1c0b9a at: https://64eddf3ac87f8e0cba723d07--layer5.netlify.app

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2 cents about the PR -

  • I think this change "might" affect the user experience.
  • However, the change made works to hold the focus on the search bar for 5 seconds. It gets held for 5 seconds to show the results which creates a bad experience.

Thoughts? @iArchitSharma

@iArchitSharma
Copy link
Contributor Author

@Mohith234 I've already discussed this in the Issue. Now, I'm trying a different approach.

@l5io
Copy link
Contributor

l5io commented Aug 29, 2023

🚀 Preview for commit 805ecce at: https://64ee1cb5c8f2221c0232a9a8--layer5.netlify.app

@leecalcote leecalcote added the area/blog New posts or new blog functionality label Aug 29, 2023
@leecalcote
Copy link
Member

Thank you, gentlemen.

@vishalvivekm
Copy link
Member

@iArchitSharma
Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

Copy link
Member

@Mohith234 Mohith234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 @iArchitSharma

@VaibhavMalik4187
Copy link

Two separate commits are not required. Can you please squash the commits?

@iArchitSharma
Copy link
Contributor Author

@VaibhavMalik4187, can you help me? I've tried, but I keep encountering an error

@VaibhavMalik4187
Copy link

@VaibhavMalik4187, can you help me? I've tried, but I keep encountering an error

And the error is?

@iArchitSharma
Copy link
Contributor Author

iArchitSharma commented Sep 7, 2023

@VaibhavMalik4187
image

When i run git log, i see only two commits: the first one is mine, and the second one is from someone else.

@VaibhavMalik4187
Copy link

@VaibhavMalik4187 image

When i run git log, i see only two commits: the first one is mine, and the second one is from someone else.

Are you on the right branch?

@iArchitSharma
Copy link
Contributor Author

@VaibhavMalik4187 image
When i run git log, i see only two commits: the first one is mine, and the second one is from someone else.

Are you on the right branch?

yes I am in the correct branch

@iArchitSharma
Copy link
Contributor Author

iArchitSharma commented Sep 10, 2023

@VaibhavMalik4187, I don't think there will be any problems. Last time, I made multiple commits, and the PR was merged.

@VaibhavMalik4187
Copy link

@VaibhavMalik4187, I don't think there will be any problems. Last time, I made multiple commits, and the PR was merged.

It is not about the problems, it is more about the right semantics. Having 2 commits for a single line change is useless in my opinion. It doesn't make any sense to bloat the git logs with unnecessary commits. Please try to learn about git rebase, it is very important when working in collaborative environments.

@iArchitSharma
Copy link
Contributor Author

iArchitSharma commented Sep 10, 2023

@VaibhavMalik4187, I don't think there will be any problems. Last time, I made multiple commits, and the PR was merged.

It is not about the problems, it is more about the right semantics. Having 2 commits for a single line change is useless in my opinion. It doesn't make any sense to bloat the git logs with unnecessary commits. Please try to learn about git rebase, it is very important when working in collaborative environments.

Thank you for your feedback, @VaibhavMalik4187. I appreciate your perspective on keeping the commit history clean and meaningful. I'll definitely look into git rebase and try to apply it appropriately in the future to maintain a more streamlined commit history.

Right now, as I mentioned, git log shows me only one commit even though I am on the correct branch. If you could help me here, I would greatly appreciate it.

@VaibhavMalik4187
Copy link

@VaibhavMalik4187, I don't think there will be any problems. Last time, I made multiple commits, and the PR was merged.

It is not about the problems, it is more about the right semantics. Having 2 commits for a single line change is useless in my opinion. It doesn't make any sense to bloat the git logs with unnecessary commits. Please try to learn about git rebase, it is very important when working in collaborative environments.

Thank you for your feedback, @VaibhavMalik4187. I appreciate your perspective on keeping the commit history clean and meaningful. I'll definitely look into git rebase and try to apply it appropriately in the future to maintain a more streamlined commit history.

Right now, as I mentioned, git log shows me only one commit even though I am on the correct branch. If you could help me here, I would greatly appreciate it.

Could you please share the outputs of:

  1. git status
  2. git branch
  3. git log --oneline

@iArchitSharma
Copy link
Contributor Author

iArchitSharma commented Sep 10, 2023

@VaibhavMalik4187 Here it is:
image

@VaibhavMalik4187
Copy link

@VaibhavMalik4187 Here it is: image

Did you shallow-clone the repo? Any reason for not branching from the latest master? I don't have prior experience working with grafted commits, so I don't think I'll be much help here. Is there anyone else who can assist @iArchitSharma with this issue?

Here is the workflow that I follow:

  1. Checkout to master. Pull the latest commits.
  2. Create a new branch from the master
  3. Make and commit the changes.
  4. Raise a pull request.
  5. Rebase my PR before merging if new changes are added to the master during the review.

@Mohith234
Copy link
Member

@iArchitSharma Please provide the updates on this issue.

@iArchitSharma
Copy link
Contributor Author

@iArchitSharma Please provide the updates on this issue.

@Prakhar-Agarwal-byte Can you help with above git rebase issue

@sudhanshutech sudhanshutech merged commit d9d206f into layer5io:master Nov 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality
Development

Successfully merging this pull request may close these issues.

Search Bar loses Focus when you don't type fast
7 participants