-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated debounceTimeout of Blog Search bar #4802
Conversation
Signed-off-by: Archit Sharma <[email protected]>
🚀 Preview for commit f1c0b9a at: https://64eddf3ac87f8e0cba723d07--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2 cents about the PR -
- I think this change "might" affect the user experience.
- However, the change made works to hold the focus on the search bar for 5 seconds. It gets held for 5 seconds to show the results which creates a bad experience.
Thoughts? @iArchitSharma
Signed-off-by: Archit Sharma <[email protected]>
@Mohith234 I've already discussed this in the Issue. Now, I'm trying a different approach. |
🚀 Preview for commit 805ecce at: https://64ee1cb5c8f2221c0232a9a8--layer5.netlify.app |
Thank you, gentlemen. |
@iArchitSharma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 @iArchitSharma
Two separate commits are not required. Can you please squash the commits? |
@VaibhavMalik4187, can you help me? I've tried, but I keep encountering an error |
And the error is? |
When i run |
Are you on the right branch? |
yes I am in the correct branch |
@VaibhavMalik4187, I don't think there will be any problems. Last time, I made multiple commits, and the PR was merged. |
It is not about the problems, it is more about the right semantics. Having 2 commits for a single line change is useless in my opinion. It doesn't make any sense to bloat the git logs with unnecessary commits. Please try to learn about git rebase, it is very important when working in collaborative environments. |
Thank you for your feedback, @VaibhavMalik4187. I appreciate your perspective on keeping the commit history clean and meaningful. I'll definitely look into git rebase and try to apply it appropriately in the future to maintain a more streamlined commit history. Right now, as I mentioned, |
Could you please share the outputs of:
|
@VaibhavMalik4187 Here it is: |
Did you shallow-clone the repo? Any reason for not branching from the latest master? I don't have prior experience working with grafted commits, so I don't think I'll be much help here. Is there anyone else who can assist @iArchitSharma with this issue? Here is the workflow that I follow:
|
@iArchitSharma Please provide the updates on this issue. |
@Prakhar-Agarwal-byte Can you help with above |
Description
This PR fixes #4788
Blog page: https://layer5.io/blog
The initial setting for debounceTimeout was 500ms (0.5 seconds), I propose to increase the debounceTimeout to 5000ms (5 seconds).
This adjustment allows the search functionality to wait for a slightly longer duration before triggering a search request. As a result, users will experience a smoother and more responsive search process, especially when they are typing multiple search terms or navigating between different search inputs.
Notes for Reviewers
Signed commits