Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra column space in mobile view #4716

Closed
wants to merge 11 commits into from

Conversation

vermabraj
Copy link

@vermabraj vermabraj commented Aug 9, 2023

Description
I have fixed this problem, there was problem in mobile/tablet view or in between 900px-1000px that i have fixed, please look at this PR
This PR fixes #
Extra column space in mobile view #4716
Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions bot added the area/landscape The service mesh landscape label Aug 9, 2023
@l5io
Copy link
Contributor

l5io commented Aug 9, 2023

🚀 Preview for commit 2f4096b at: https://64d3c454d41d05009d88099b--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

abhijeetgauravm commented Aug 9, 2023

@vermabraj Please mention this PR fixes which #issue ? and also sign off your commit as DCO check is failing!

@leecalcote
Copy link
Member

Thank you, @vermabraj

@vermabraj
Copy link
Author

vermabraj commented Aug 10, 2023

@leecalcote thank you to you as well, now its done or needs to do anything for this PR or issue

@l5io
Copy link
Contributor

l5io commented Aug 10, 2023

🚀 Preview for commit a414803 at: https://64d46ed4e507b22c775dccf0--layer5.netlify.app

@leecalcote
Copy link
Member

@leecalcote thank you to you as well, now its done or needs to do anything for this PR or issue

@abhijeetgauravm‘a feedback needs addressed and resolved by you (see the instructions available on this page) and another maintainer needs to offer review.

@Chadha93
Copy link
Member

@abhijeetgauravm No update?

@github-actions
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@l5io
Copy link
Contributor

l5io commented Aug 24, 2023

🚀 Preview for commit c644d82 at: https://64e7269f76cd9c64a08b7a9e--layer5.netlify.app

@vermabraj
Copy link
Author

@leecalcote can anyone help me with DCO failed issue ?

@leecalcote
Copy link
Member

leecalcote commented Aug 24, 2023

@vermabraj follow the instructions in the details link of the failed check.

@l5io
Copy link
Contributor

l5io commented Aug 29, 2023

🚀 Preview for commit d61c24b at: https://64ee2c594fe00e0673622406--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Aug 31, 2023

🚀 Preview for commit 17c9337 at: https://64f0d3302e5ef21687f18847--layer5.netlify.app

@vishalvivekm
Copy link
Member

@vermabraj
Still missing DCO @vermabraj and conflicts.
Please address these issues.

@Chadha93
Copy link
Member

@vermabraj Please mention this PR fixes which #issue ? and also sign off your commit as DCO check is failing!

@vermabraj This is still unaddressed, please consider opening the issue first. I'm closing this issue seeing no response and and activity.

@Chadha93 Chadha93 closed this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/landscape The service mesh landscape issue/dco
Development

Successfully merging this pull request may close these issues.

6 participants