-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Feat : Added inactive banner #4623
Conversation
Signed-off-by: Vikram <[email protected]>
Signed-off-by: Vikram <[email protected]>
This reverts commit 1cc4c00. Signed-off-by: Vikram <[email protected]>
I sticked to using px instead of rem as the banner of HPE on homepage also preferred px . |
🚀 Preview for commit 5536d54 at: https://64c0e087742e2d40f784b4d3--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ghat0tkach, thanks for this, make the ribbon grayed out too, please.
thank you @thisiskaransgit , Actually I started with the grayed out ribbon but it looked plain simple, that's why I switched to gradient. Shall I change it back to gray?? |
@Ghat0tkach, yeah keep them grayed out. |
Signed-off-by: Vikramaditya Singh <[email protected]>
🚀 Preview for commit 60ede47 at: https://64c123a2a88d290d220ca93e--layer5.netlify.app |
@thisiskaransgit , done 🙌 |
Don't highlight their inactivity with a green ribbon. Make the ribbon gray as well. In fact, please use a different ribbon, going horizontally across the card. |
@lee , Shall I use this alignment of ribbon? or position it below the name ? And also Im a bit confuse about the background color of ribbon as well. |
Looking good, @Ghat0tkach 👍 How is working in mobile view? Just fine? |
Kind, sir, will you also use the same gray filter on the single member page for inactive profiles with the same ribbon, too? |
@lee , yes its fully responsive and I'll add the filter along with ribbon on the single-member profile as well Sir |
Thank you. Moving forward with this first step... |
Description
This PR fixes #4621
Notes for Reviewers
Added Inactive Banner for inactive member profiles
Signed commits