Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Feat : Added inactive banner #4623

Merged
merged 4 commits into from
Jul 26, 2023
Merged

[Enhancement] Feat : Added inactive banner #4623

merged 4 commits into from
Jul 26, 2023

Conversation

Ghat0tkach
Copy link
Member

@Ghat0tkach Ghat0tkach commented Jul 26, 2023

Description

This PR fixes #4621

Notes for Reviewers
Added Inactive Banner for inactive member profiles
image

Signed commits

  • Yes, I signed my commits.

@Ghat0tkach
Copy link
Member Author

Ghat0tkach commented Jul 26, 2023

I sticked to using px instead of rem as the banner of HPE on homepage also preferred px .

@l5io
Copy link
Contributor

l5io commented Jul 26, 2023

🚀 Preview for commit 5536d54 at: https://64c0e087742e2d40f784b4d3--layer5.netlify.app

Copy link
Contributor

@thisiskaransgit thisiskaransgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ghat0tkach, thanks for this, make the ribbon grayed out too, please.

@Ghat0tkach
Copy link
Member Author

@Ghat0tkach, thanks for this, make the ribbon grayed out too, please.

thank you @thisiskaransgit , Actually I started with the grayed out ribbon but it looked plain simple, that's why I switched to gradient.
image

Shall I change it back to gray??

@thisiskaransgit
Copy link
Contributor

@Ghat0tkach, yeah keep them grayed out.

Signed-off-by: Vikramaditya Singh <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 26, 2023

🚀 Preview for commit 60ede47 at: https://64c123a2a88d290d220ca93e--layer5.netlify.app

@Ghat0tkach
Copy link
Member Author

@thisiskaransgit , done 🙌

@leecalcote
Copy link
Member

Don't highlight their inactivity with a green ribbon. Make the ribbon gray as well.

In fact, please use a different ribbon, going horizontally across the card.

@Ghat0tkach
Copy link
Member Author

Don't highlight their inactivity with a green ribbon. Make the ribbon gray as well.

In fact, please use a different ribbon, going horizontally across the card.

@lee , Shall I use this alignment of ribbon? or position it below the name ? And also Im a bit confuse about the background color of ribbon as well.

image
image

@leecalcote
Copy link
Member

Looking good, @Ghat0tkach 👍

How is working in mobile view? Just fine?

@leecalcote
Copy link
Member

Kind, sir, will you also use the same gray filter on the single member page for inactive profiles with the same ribbon, too?

@Ghat0tkach
Copy link
Member Author

Kind, sir, will you also use the same gray filter on the single member page for inactive profiles with the same ribbon, too?

@lee , yes its fully responsive

and I'll add the filter along with ribbon on the single-member profile as well Sir

@leecalcote
Copy link
Member

Thank you. Moving forward with this first step...

@leecalcote leecalcote merged commit 973d8d2 into layer5io:master Jul 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Enhancement] "Inactive" Ribbon On Inactive members profile.
4 participants