Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Member #4565

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Add Member #4565

merged 5 commits into from
Jul 24, 2023

Conversation

devarsh10
Copy link
Contributor

Description
Signed-off-by: devarsh10 [email protected]
This PR fixes #4556

Notes for Reviewers
Add @HarshDobariya47 as a Member.

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 18, 2023

🚀 Preview for commit de109cc at: https://64b623d8374e6d28373d9926--layer5.netlify.app

Copy link
Contributor

@HetviSoni HetviSoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@samyakshah3008 samyakshah3008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work @devarsh10
But can you please change the title of the PR? It is not relevant to what issue you are working on.

@samyakshah3008
Copy link
Member

@HarshDobariya79 can you review this so we can call for the final checks to get this PR merged?

Copy link
Member

@HarshDobariya79 HarshDobariya79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @devarsh10 for the PR. Nice work.

@devarsh10 devarsh10 changed the title Devarsh patch 2 Add Member Jul 19, 2023
@devarsh10
Copy link
Contributor Author

Thank you @devarsh10 for the PR. Nice work.

My pleasure Harsh.

@l5io
Copy link
Contributor

l5io commented Jul 19, 2023

🚀 Preview for commit 177fa98 at: https://64b7e42106e65a1272e006c7--layer5.netlify.app

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🎈 Harsh 🎸

Thank you @devarsh10 😎

Copy link
Member

@Chadha93 Chadha93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go. 🚀

@Chadha93 Chadha93 merged commit f0c1bfc into layer5io:master Jul 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Community] Member Profile: Harsh Dobariya
7 participants