-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the catalog assets. #4563
Conversation
Signed-off-by: Xiao Ran <[email protected]>
🚀 Preview for commit 349bd06 at: https://64b5784bcd662a302de3ed30--layer5.netlify.app |
Can you please add the catalog logo as on layer5 home page? |
@goldfishdolphin Sure, but I thought the logo was already here, where do you want to put it? |
Can you please add it to the assets ? |
@xiaor2 Let's discuss this on Websites Meeting call on Monday. Please add this as an agenda item in the meeting mintes if you would. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hii @xiaor2 , great work on the PR ,
however the download logo assets point to download all the brand kit
rather than specifically downloading the sole logo assets
Thanks for this feedback, @goldfishdolphin and @Ghat0tkach |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
Thanks for the feedbacks! I am moving to another apartment these days. And I will work on this soon. |
Signed-off-by: Xiao Ran <[email protected]>
Hi, I have fixed the link. |
🚀 Preview for commit 52bee34 at: https://64d058ec8bc4d0290f6513ca--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍🏽
Let's discuss it on the websites call. We do have our weekly website meetings at 7:00 AM CT . |
Sure. See you in the meeting! |
@xiaor2 Merge conflicts.... |
@ritiksaxena124 All good here? I think @xiaor2 has some feedback to incorporate from last website's meeting.... |
Signed-off-by: Xiao Ran <[email protected]>
Signed-off-by: Xiao Ran <[email protected]>
Signed-off-by: Xiao Ran <[email protected]>
🚀 Preview for commit d41568a at: https://64dcfca5580f87094f5e92a6--layer5.netlify.app |
🚀 Preview for commit 2ae7cde at: https://64dd10b3a04ce10de00ec860--layer5.netlify.app |
Deleting the cache folder may help. |
Thanks! That works. And I made some changes based on the feedback I received from the last meeting. Let me know if anyone has more suggestions. |
Looking good 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Looks good @xiaor2, one last change will you increase the size of the icon in the box and do you know why the catalog icons doesn't zoom in like other icons on the page on click? |
Description
This PR fixes #
Notes for Reviewers
Signed commits