Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the catalog assets. #4563

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Added the catalog assets. #4563

merged 7 commits into from
Aug 23, 2023

Conversation

xiaor2
Copy link
Contributor

@xiaor2 xiaor2 commented Jul 17, 2023

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 17, 2023

🚀 Preview for commit 349bd06 at: https://64b5784bcd662a302de3ed30--layer5.netlify.app

@goldfishdolphin
Copy link
Contributor

Can you please add the catalog logo as on layer5 home page?

@xiaor2
Copy link
Contributor Author

xiaor2 commented Jul 18, 2023

@goldfishdolphin Sure, but I thought the logo was already here, where do you want to put it?
image

@goldfishdolphin
Copy link
Contributor

Can you please add it to the assets ?

@xiaor2
Copy link
Contributor Author

xiaor2 commented Jul 19, 2023

Sure, does this look good to you?
image

@vishalvivekm
Copy link
Member

@xiaor2 Let's discuss this on Websites Meeting call on Monday. Please add this as an agenda item in the meeting mintes if you would. :)

Copy link
Member

@Ghat0tkach Ghat0tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @xiaor2 , great work on the PR ,
however the download logo assets point to download all the brand kit
rather than specifically downloading the sole logo assets

@leecalcote
Copy link
Member

Thanks for this feedback, @goldfishdolphin and @Ghat0tkach

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@xiaor2
Copy link
Contributor Author

xiaor2 commented Aug 3, 2023

Thanks for the feedbacks! I am moving to another apartment these days. And I will work on this soon.

@xiaor2
Copy link
Contributor Author

xiaor2 commented Aug 7, 2023

Hi, I have fixed the link.

@l5io
Copy link
Contributor

l5io commented Aug 7, 2023

🚀 Preview for commit 52bee34 at: https://64d058ec8bc4d0290f6513ca--layer5.netlify.app

Copy link
Contributor

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍🏽

@Ghat0tkach
Copy link
Member

@xiaor2

Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

We do have our weekly website meetings at 7:00 AM CT .

@xiaor2
Copy link
Contributor Author

xiaor2 commented Aug 7, 2023

Sure. See you in the meeting!

@Chadha93
Copy link
Member

@xiaor2 Merge conflicts....

@Chadha93
Copy link
Member

@ritiksaxena124 All good here? I think @xiaor2 has some feedback to incorporate from last website's meeting....

@xiaor2 xiaor2 closed this Aug 16, 2023
@xiaor2 xiaor2 reopened this Aug 16, 2023
Signed-off-by: Xiao Ran <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 16, 2023

🚀 Preview for commit d41568a at: https://64dcfca5580f87094f5e92a6--layer5.netlify.app

@xiaor2
Copy link
Contributor Author

xiaor2 commented Aug 16, 2023

Hi, I met an issue when I ran make site after I pulled from the origin/master. Does anyone know why this happen?
image

@l5io
Copy link
Contributor

l5io commented Aug 16, 2023

🚀 Preview for commit 2ae7cde at: https://64dd10b3a04ce10de00ec860--layer5.netlify.app

@goldfishdolphin
Copy link
Contributor

Deleting the cache folder may help.

@xiaor2
Copy link
Contributor Author

xiaor2 commented Aug 16, 2023

Thanks! That works. And I made some changes based on the feedback I received from the last meeting. Let me know if anyone has more suggestions.

@goldfishdolphin
Copy link
Contributor

Thanks! That works. And I made some changes based on the feedback I received from the last meeting. Let me know if anyone has more suggestions.

Looking good 👍🏽

Copy link
Contributor

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ritiksaxena124
Copy link
Contributor

Looks good @xiaor2, one last change will you increase the size of the icon in the box and do you know why the catalog icons doesn't zoom in like other icons on the page on click?

@Chadha93 Chadha93 merged commit 83301ca into layer5io:master Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

9 participants