Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolved Responsive issue with the Subscribe section [Footer] #4466

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Resolved Responsive issue with the Subscribe section [Footer] #4466

merged 1 commit into from
Jul 3, 2023

Conversation

vednp
Copy link

@vednp vednp commented Jul 1, 2023

Description

This PR fixes #4462

Notes for Reviewers
Fixed Overlap occurring on specific window sizes of the Subscribe section

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jul 1, 2023

🚀 Preview for commit 6786b02 at: https://64a06675967a46527b58ec59--layer5.netlify.app

@Ghat0tkach
Copy link
Member

LGTM , Have you checked on smaller screens as well (just to make sure)?

@vednp
Copy link
Author

vednp commented Jul 1, 2023

LGTM , Have you checked on smaller screens as well (just to make sure)?

Yeah, I checked for all screen sizes

@Ghat0tkach
Copy link
Member

// @vishalvivekm @thisiskaransgit

@vishalvivekm
Copy link
Member

@vednp Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :)

@vednp
Copy link
Author

vednp commented Jul 2, 2023

@vednp Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :)

Sorry, I don't get it can you explain?

@Ghat0tkach
Copy link
Member

@vednp Let's discuss this on the Websites call. Please add this as an agenda item in the meeting minutes if you would. :)

Sorry, I don't get it can you explain?

We have weekly meetings on Monday to discuss about PRs , issues and the problems faced by contributors .
Adding this in meeting minutes implies to add this as an agenda item to be discussed in the meeting 😅🙌.

hirentimbadiya
hirentimbadiya approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@hirentimbadiya hirentimbadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

DarrenDsouza7273
DarrenDsouza7273 approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@DarrenDsouza7273 DarrenDsouza7273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @vednp

@vednp
Copy link
Author

vednp commented Jul 2, 2023

Good work @vednp

Thanks @DarrenDsouza7273 I really appreciate your kind words.

@leecalcote
Copy link
Member

Thank you, @vednp

@leecalcote leecalcote merged commit 43a44b2 into layer5io:master Jul 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

@hirentimbadiya hirentimbadiya hirentimbadiya approved these changes

@DarrenDsouza7273 DarrenDsouza7273 DarrenDsouza7273 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Footer] Responsive issue with the Subscribe section
7 participants
@vednp @l5io @Ghat0tkach @vishalvivekm @leecalcote @hirentimbadiya @DarrenDsouza7273