-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-member-profile-of-philip #4441
add-member-profile-of-philip #4441
Conversation
Signed-off-by: vishalvivekm <[email protected]>
🚀 Preview for commit 93f3994 at: https://6499aafdf5da58035d22505e--layer5.netlify.app |
@vishalvivekm be sure to assign Philip for review. |
Hi @Philip-21 |
🚀 Preview for commit 93f3994 at: https://649b13f27e004b114a486de7--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge from my side ✅
We can wait for Philip to review his own member's profile before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bio: I am a backend developer passionate in developing server side Software. An adept Gopher with an enthusiasm for Open source and continuous learning. I have high interest in Cloud computing and Kubernetes. | ||
status: Active | ||
published: true | ||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the meshery
badge to Philip's profile ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I just accepted the badge 🙂
Everything is perfect everyone thanks 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍🏽
twitter: Philip_obiora21 | ||
linkedin: philip-obiora-aa09401a9 | ||
location: Lagos, Nigeria | ||
bio: I am a backend developer passionate in developing server side Software. An adept Gopher with an enthusiasm for Open source and continuous learning. I have high interest in Cloud computing and Kubernetes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make Software in lowercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch. While we're at it, let's lowercase "Open source" and "Cloud", too.
@goldfishdolphin, perhaps, you'd like to make these changes directly. Press CTL+G (or CMD+G) while inside of a comment and you should be able to suggest these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a great idea 💡
Signed-off-by: Vivek Vishal <[email protected]>
🚀 Preview for commit b5b6ee0 at: https://649ea84739c2255b1434a02f--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Whee! 🎈 |
Description
This PR fixes #4440
Notes for Reviewers
Signed commits