Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-member-profile-of-philip #4441

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

vishalvivekm
Copy link
Member

Description

This PR fixes #4440

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: vishalvivekm <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jun 26, 2023

🚀 Preview for commit 93f3994 at: https://6499aafdf5da58035d22505e--layer5.netlify.app

@leecalcote
Copy link
Member

@vishalvivekm be sure to assign Philip for review.

@vishalvivekm
Copy link
Member Author

Hi @Philip-21
Please have a look at your profile : layer5.io/community/members

@l5io
Copy link
Contributor

l5io commented Jun 27, 2023

🚀 Preview for commit 93f3994 at: https://649b13f27e004b114a486de7--layer5.netlify.app

Copy link
Member

@samyakshah3008 samyakshah3008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge from my side ✅
We can wait for Philip to review his own member's profile before merging.

Copy link
Contributor

@DarrenDsouza7273 DarrenDsouza7273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote
Copy link
Member

@Philip-21?

bio: I am a backend developer passionate in developing server side Software. An adept Gopher with an enthusiasm for Open source and continuous learning. I have high interest in Cloud computing and Kubernetes.
status: Active
published: true
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the meshery badge to Philip's profile ✅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I just accepted the badge 🙂

@Philip-21
Copy link
Member

Everything is perfect everyone thanks 😊

Copy link
Contributor

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍🏽

twitter: Philip_obiora21
linkedin: philip-obiora-aa09401a9
location: Lagos, Nigeria
bio: I am a backend developer passionate in developing server side Software. An adept Gopher with an enthusiasm for Open source and continuous learning. I have high interest in Cloud computing and Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make Software in lowercase?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. While we're at it, let's lowercase "Open source" and "Cloud", too.

@goldfishdolphin, perhaps, you'd like to make these changes directly. Press CTL+G (or CMD+G) while inside of a comment and you should be able to suggest these changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a great idea 💡

@l5io
Copy link
Contributor

l5io commented Jun 30, 2023

🚀 Preview for commit b5b6ee0 at: https://649ea84739c2255b1434a02f--layer5.netlify.app

Copy link
Contributor

@goldfishdolphin goldfishdolphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@leecalcote
Copy link
Member

Whee! 🎈

@leecalcote leecalcote merged commit 135a1f5 into layer5io:master Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Community] Member Profile: Philip
7 participants