Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Home] Banner: add button to playground #4389

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

leecalcote
Copy link
Member

Signed-off-by: Lee Calcote [email protected]

Description

This PR has a bug in which the new button icon is not being properly imported.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Lee Calcote <[email protected]>
@leecalcote
Copy link
Member Author

@Shivam-AfA, help needed, please.

@Shivam-AfA
Copy link
Contributor

@leecalcote Looking into this.

@leecalcote
Copy link
Member Author

@leecalcote Looking into this.

@Shivam-AfA any luck?

@Shivam-AfA
Copy link
Contributor

@leecalcote The @react-icons/all-files/bs package does not contain the filled right upper arrow. Can we use this arrow instead of that?

image

@leecalcote
Copy link
Member Author

@Shivam-AfA ok, yes.

Signed-off-by: Shivam Sood <[email protected]>
@Shivam-AfA
Copy link
Contributor

Alright, pushing and merging...

@Shivam-AfA Shivam-AfA merged commit f3ff218 into master Jun 23, 2023
@Shivam-AfA Shivam-AfA deleted the leecalcote/homepage/banner-button branch June 23, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants