Card should be clickable (Sistent/Components) #5696
Comments
Muhammed-Moinuddin
added
kind/enhancement
|
This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.
|
1 similar comment
|
This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.
|
|
@Muhammed-Moinuddin Please confirm whether this is an issue or a design choice. |
Not an issue. It is a feature request. |
|
If you are looking for someone to work on this issue then let me know as i am interested in working on this issue. @Muhammed-Moinuddin |
I'll assign it to you. Let me just confirm this feature request first. |
|
@Muhammed-Moinuddin If we do so, then there will be ask for major changes in card as learn more section of the card will not be a valid UX!! So, it doesn't make any sense ig!! Well, let's have some suggestions @sudhanshutech @hargunkaur286? |
Discussion is important, but I disagree with your opinion. It will make UX better. Cards on other places of website also support this feature. |
|
@Muhammed-Moinuddin Thank you for opening it. Let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes |
Yes. |
|
Hii @Muhammed-Moinuddin and @Ashparshp , if this issue is still valid i would like to work on it. |
|
@AnkityadavIITR Not decided yet. Make sure to join us for the Monday call for more! |
|
@Muhammed-Moinuddin @vishalvivekm As we discussed, this is not going to be implemented, so I am closing this as Not Planned. |
No worries. But @Rexford74 suggested that whole card should be clickable via slack. |
|
@Muhammed-Moinuddin No idea about it.. I'll be reopening it.. |
|
@Muhammed-Moinuddin @narasimha-1511 , Could you please assign it to me |
|
Go on @DevMhrn 🚀 |
Signed-off-by: DevMhrn <[email protected]>
|
@Muhammed-Moinuddin I have made the pull request, and solved it , could you please review it |
Let's review this in tomorrows website meeting. https://layer5.io/community/calendar |
|
@Muhammed-Moinuddin @Ashparshp Please check the updated pr , I have made the changes . |
|
@Ashparshp @Muhammed-Moinuddin could you please review this pr, and check if it mergable or not |
|
@DevMhrn Were you in the last Monday call? We had a discussion about it. |
|
@Ashparshp I was unable to join the meeting, but i watched the recording later and i corrected the code and made the changes , and also @Muhammed-Moinuddin asked to fix the title color which i missed earlier and now everything looks good , could you please review it. |
|
You have not followed all the requested changes. The PR also have DCO issues. |
|
@Muhammed-Moinuddin I think i have solved the issue related to the review i was given in the last meeting , you can check now , it works on different themes and same color changes as you asked to do. But still I will attend the monday meeting , by the way how will i join the meeting @Ashparshp ? |
Fixed issue #5696 : Made the card clickable
Signed-off-by: DevMhrn <[email protected]>
Current Behavior
Card is not clickable(not leading to target page), just Learn More button is clickable.
Desired Behavior
Whole card (eg, Sistent/Component/Button Card) should be clickable and leading to proper page.
Screenshots / Mockups
2024-07-19.12-31-31.mp4
Implementation
Acceptance Tests
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the
masterbranch.The text was updated successfully, but these errors were encountered: