Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Hyperlink added for each Role name from Permissions Reference page to Roles page #329

Closed
wants to merge 0 commits into from

Conversation

SAHU-01
Copy link
Contributor

@SAHU-01 SAHU-01 commented Jul 20, 2024

Notes for Reviewers

This PR fixes #321

A hyperlink for all available roles in doc has been added and the ones that are not documented in Roles for now (ex: User) are redirected to the default roles page.

Refer to the changes below:

option2.mov

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit c2f68c7
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/66a672f230e8fa00087a85ec
😎 Deploy Preview https://deploy-preview-329--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member

@SAHU-01
Thank you for your contribution.
Let's discuss this on Websites' call. Adding this as an agenda item into the meeting minutes.

@leecalcote
Copy link
Member

@dragon-slayer875 @Yashsharma1911 your 👀s here, if you would.

@dragon-slayer875
Copy link
Contributor

@SAHU-01 Hello! It seems you missed adding support for the other roles based sorted table, so that they can link to the pages.
Would you mind making updates so that is also accounted for?

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Jul 28, 2024

@dragon-slayer875 Could share an example for this?
I'm unable to figure this other roles based sorted table out ?

@dragon-slayer875
Copy link
Contributor

@SAHU-01 I mean this section. The table has two modes, one sorted by permission category, and the other sorted by roles. I don't think your changes account for this table sorted by roles?
image

@dragon-slayer875
Copy link
Contributor

@SAHU-01 Will you be making a separate PR for this?

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Jul 28, 2024

@dragon-slayer875 yes, I don't have a lot of the recent commits [including this sorted table thing] so locally I was unable to check a lot of things, owing to merge conflicts I'll send a fresh PR in a couple of minutes with these changes.

@SAHU-01
Copy link
Contributor Author

SAHU-01 commented Jul 28, 2024

@dragon-slayer875 you can find the new PR with all the changes here: #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Hyperlink each Role name from Permissions Reference page to Roles page
4 participants