Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add option to sort permissions table by roles #326

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

dragon-slayer875
Copy link
Contributor

Notes for Reviewers

This PR fixes #323

image

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 6773918
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/669bfa1ccc9d660008413f3f
😎 Deploy Preview https://deploy-preview-326--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leecalcote
Copy link
Member

It'd be helpful if the first column was that of the functionality category; if a new column was added.

@dragon-slayer875
Copy link
Contributor Author

It'd be helpful if the first column was that of the functionality category; if a new column was added.

Do you mean that the first column should pick from the 'function' column of our permissions sheet?
If yes, then it is infact that very column, I had just renamed the header, but I can name it to functionality/function if that serves our purpose better.

@leecalcote
Copy link
Member

Checking in...

@dragon-slayer875 dragon-slayer875 merged commit eb3bf75 into layer5io:master Jul 20, 2024
6 checks passed
@dragon-slayer875
Copy link
Contributor Author

Merging the PR to allow contributers working on other related issues to update this table simultaneously.
Will be making a separate PR for the required changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Docs] Permissions by Role
2 participants