Responsive helm values table branch #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishikesh Maddhesiya <[email protected]>
Signed-off-by: Rishikesh Maddhesiya <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
GaganpreetKaurKalsi
suggested changes
Jun 23, 2024
Comment on lines
+8
to
+13
| <style> | ||
| .table-container { | ||
| overflow-x: auto; | ||
| max-width: 100%; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Could you move table-container styles to _content_project.scss file beside other table related styles?
Also I think having a max-width for each column would be good so data is easily accessible @iArchitSharma
There was a problem hiding this comment.
@Rishikesh63 @GaganpreetKaurKalsi Please do this in another PR if you would; this needs to be merged urgently.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #269
made scrolable values table
Customizing.Layer5.Cloud.Deployment.with.Helm._.Layer5.Documentation.-.Google.Chrome.2024-06-22.00-52-57.mp4
Signed commits