Adding Labeler workflow #188
Conversation
Signed-off-by: Shubham Srivastava <[email protected]>
Signed-off-by: Shubham Srivastava <[email protected]>
Signed-off-by: Shubham Srivastava <[email protected]>
Signed-off-by: Shubham Srivastava <[email protected]>
Signed-off-by: Shubham Srivastava <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Shubham Srivastava <[email protected]>
iArchitSharma
added
pr/do-not-merge
.github/labeler.yml
Outdated
| component/cloud-docs: | ||
| - label: bug | ||
| paths: | ||
| - "content/en/meshmap/**/*" |
There was a problem hiding this comment.
Why are you labeling meshmap content with component-cloud-docs? Don't.
|
Add |
| @@ -0,0 +1,11 @@ | |||
|
|
|||
| component/cloud-docs: | |||
There was a problem hiding this comment.
@surajvast1 this should be component/meshmap-docs as meshmap content is changed
also create one for component/cloud-docs too
There was a problem hiding this comment.
@iArchitSharma Sure I assumed both to be under a single label .
I'll make the changes
There was a problem hiding this comment.
@surajvast1 don't include meshery-docs here. That is a separate site. Use meshmap for meshmap.
One more chance to get this right. If you don't this time time, let's close this PR and allow another contributor a turn.
There was a problem hiding this comment.
@leecalcote I guess there is a lack of communication here . I implemented it correctly before but as @iArchitSharma ask me to add component/meshmap-docs i changed it . Its updated now
Signed-off-by: surajvast1 <[email protected]>
Signed-off-by: Shubham Srivastava <[email protected]>
|
Hi @surajvast1 , You're welcome at the meeting Check to community calendar for more details of meetings at Layers. |
Signed-off-by: Shubham Srivastava <[email protected]>
Signed-off-by: Shubham Srivastava <[email protected]>
|
@iArchitSharma its updated and good to go |
|
@Yashsharma1911 can you please check if it works correctly ? |
| @@ -0,0 +1,11 @@ | |||
|
|
|||
| component/cloud-docs: | |||
There was a problem hiding this comment.
@surajvast1 don't include meshery-docs here. That is a separate site. Use meshmap for meshmap.
One more chance to get this right. If you don't this time time, let's close this PR and allow another contributor a turn.
Signed-off-by: surajvast1 <[email protected]>
|
I have tested the labeler workflow at my end it works perfectly. Test2) Updating a file in this path content/en/cloud so it again does not adds labeler Test3) Updating a file in the path content/en/meshmap/**/* as mentioned in the error .So you can see labeler here Please consider it ,apologies for the miscommunication ,Thanks. |
|
good deal. @iArchitSharma are we good to go? |
leecalcote
requested review from
leecalcote,
hamza-mohd and
iArchitSharma
and removed request for
leecalcote
|
@surajvast1 the request was to add the meshmap label when the meshmap docs are edited and add the cloud label when cloud docs are edited. Your pull request only adds the 'cloud' labeler to both." |
|
Now you have added meshery-docs label . I hope it maches the requirements.Thanks I got to learn a lot working on this . |
|
@surajvast1 It is meshmap docs label which is different from meshery |
Notes for Reviewers
This PR fixes #155
Signed commits