Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved Add alt text to the images in docs #116 #118

Merged
merged 4 commits into from
Dec 26, 2023
Merged

Solved Add alt text to the images in docs #116 #118

merged 4 commits into from
Dec 26, 2023

Conversation

surajvast1
Copy link
Contributor

@surajvast1 surajvast1 commented Dec 21, 2023 •
edited
Loading

Notes for Reviewers

This PR fixes #116

Signed commits

  • Yes, I signed my commits.

@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited
Loading

✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit eb14841
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/65870a0f54bd7a0008baeb88
😎 Deploy Preview https://deploy-preview-118--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surajvast1 surajvast1 closed this Dec 22, 2023
@surajvast1 surajvast1 reopened this Dec 22, 2023
iArchitSharma
iArchitSharma suggested changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajvast1 Can you please keep the original formatting in hugo.toml ?

@surajvast1
Copy link
Contributor Author

@surajvast1 Can you please keep the original formatting in hugo.toml ?

As in about the page format or the code please specify your questions if its page format i have already done if its about code then we need to do the changes in toml file by adding alt

@surajvast1
Copy link
Contributor Author

If you think this is complete, could you please merge it? I'm also willing to assist in any way possible."

@abhijeetgauravm
Copy link

Hey @surajvast1 Let's discuss this on website call today at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

iArchitSharma
iArchitSharma approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @surajvast1

@iArchitSharma
Copy link
Contributor

@surajvast1 make sure to always sign off your commit, otherwise DCO check fails

@surajvast1
Copy link
Contributor Author

Okay I'll make sure that, is it ok for now?

@leecalcote
Copy link
Member

Excellent!

@leecalcote leecalcote merged commit 378402e into layer5io:master Dec 26, 2023
4 of 5 checks passed
@surajvast1
Copy link
Contributor Author

Thankyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iArchitSharma iArchitSharma iArchitSharma approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add alt text to the images in docs
4 participants
@surajvast1 @abhijeetgauravm @iArchitSharma @leecalcote