Added new padding widget #448
Conversation
|
Is there any more information about this PR? There is no documentation to support it. It looks like this is a widget which can be used to add padding to a layout. So not dissimilar to a Box but you can size it as characters rather than pixels? Is that right? My first thought is that there are lots of others ways of implementing padding. Modify Box, add padding properties to existing widgets. If implementing a Padding widget how could it support other sizes? I'll put some comments against the commit. |
| def __init__( | ||
| self, | ||
| master, | ||
| size=None, |
There was a problem hiding this comment.
Is there a benefit of having a padding with a None size?
| # ---------------------------------- | ||
| # The text value | ||
| @property | ||
| def value(self): |
There was a problem hiding this comment.
Should you be able to set the value of some Padding?
| # METHODS | ||
| # ------------------------------------------- | ||
|
|
||
| # Clear text (set to empty string) |
There was a problem hiding this comment.
Clear and append methods for a Padding seem superfluous.
| from . import utilities as utils | ||
| from .base import TextWidget | ||
|
|
||
| class Padding(TextWidget): |
There was a problem hiding this comment.
By inheriting from TextWidget a Padding will inherit all the properties of a widget with text. Need to check if a padding should support the attributes of a TextWidget.
| grid=None, | ||
| align=None, | ||
| visible=True, | ||
| enabled=None, |
There was a problem hiding this comment.
Can a Padding be enabled / disabled?
|
@Captain-Toad please dont take my comments as criticism :) adding a new widget to guizero can have a significant impact and should be done after consideration of other options and the potential issues this could cause. Thank you for your contribution, is useful to continue the conversation. |
|
Referencing issue #361 |
|
Sorry about that. I could not see any other way to create padding other than the |
Size of padding can be controlled in pt, with size=XX.