Always on /alertmanager and /grafana - #7
Merged
Merged
Conversation
Remove nil-gates so /alertmanager and /grafana routes are registered unconditionally. When config sections are absent, empty defaults are used. This is a zero-config approach: endpoints work out of the box. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- docs/integrations.md: note that endpoints are enabled by default - docs/configuration.md: mark alertmanager/grafana sections as optional - plan status: Proposed -> Done Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Unconditional route registration caused enqueue mode to expose alertmanager/grafana endpoints as 500 (not configured) instead of the previous clean 404. Restore nil-guards in server.go so routes are only registered when WithAlertmanager/WithGrafana options are provided. Since runServe always provides these options now, the always-on behavior in serve mode is preserved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The plan described unconditional route registration and 500 for library users, but review iteration 1 intentionally restored nil-guards to prevent enqueue mode regression. Update plan sections 2-4 and backward compatibility to match the actual implementation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.