-
Notifications
You must be signed in to change notification settings - Fork 45
chore: Ensure memory store operations are atomic #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5323da to
a89650b
Compare
bf82505 to
a6b2b3d
Compare
a89650b to
494e635
Compare
kinyoklion
reviewed
Nov 7, 2025
| semver = ">=2.10.2" | ||
| urllib3 = ">=1.26.0,<3" | ||
| launchdarkly-eventsource = ">=1.2.4,<2.0.0" | ||
| launchdarkly-eventsource = ">=1.4.0,<2.0.0" |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to be in this PR? Or rebase problem?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been in a previously merged PR. Not sure how that was missed.
kinyoklion
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduce
ReadOnlyStoreand refactor FDv2 store/application logic to use an in-memory read-only active store withset_basis/apply_delta, persisting deltas via upserts (including tombstones); update client, interfaces, protocol, tests, and bumplaunchdarkly-eventsource.InMemoryFeatureStoreimplementingReadOnlyStorewithset_basisandapply_delta.Storeto:Changelists to collections; onTRANSFER_FULLcallset_basis, onTRANSFER_CHANGEScallapply_delta.upsert(including DELETE as tombstone objects) when writable; remove directdeletecalls.FeatureStoreClientWrapper/persistence wiring;get_active_storenow returnsReadOnlyStore.ReadOnlyStoreviaDataSystem.store; client/evaluator now read fromReadOnlyStore.ReadOnlyStoreprotocol and updateDataSystem/implementations to return it.Change.objecttype toOptional[dict].deletedwhen computing dependencies.launchdarkly-eventsourceto>=1.4.0,<2.0.0.Written by Cursor Bugbot for commit 8bcddb1. This will update automatically on new commits. Configure here.