-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: annotate pure functions #947
Conversation
🦋 Changeset detectedLatest commit: 55b7d9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +145 B (0%) Total Size: 161 kB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Summary
Vite does not add pure annotations for some top-level functions due to esbuild decisions. We can use a rollup plugin to achieve this and improve tree shaking.
Testing approaches
Built packages have
/* @__PURE__ */
annotation next toforwardRef
,cloneElement
, etc.