Skip to content

fix(components): warning Tag variant and token added #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 21, 2025

Conversation

Zuzze
Copy link
Contributor

@Zuzze Zuzze commented Jul 17, 2025

Summary

warning feedback token styles and Tag warning variant is needed commonly in design but was not available.

Screenshots (if appropriate):

New Warning variant added for Tag

image image

New tokens for warning bg and text.

image

Testing approaches

Variant added in the story and tested in dark and light mode.

Snapshot test for color tokens updated.

@Zuzze Zuzze requested review from a team as code owners July 17, 2025 22:17
Copy link

pkg-pr-new bot commented Jul 17, 2025

yarn add https://pkg.pr.new/@launchpad-ui/[email protected]
yarn add https://pkg.pr.new/@launchpad-ui/[email protected]
yarn add https://pkg.pr.new/@launchpad-ui/[email protected]

commit: 85f0936

Copy link
Contributor

github-actions bot commented Jul 17, 2025

Size Change: +292 B (+0.06%)

Total Size: 526 kB

Filename Size Change
apps/vscode/dist/server.js 261 kB +79 B (+0.03%)
packages/box/dist/index.es.js 7.26 kB +19 B (+0.26%)
packages/box/dist/index.js 7.82 kB +19 B (+0.24%)
packages/components/dist/index.es.js 17.5 kB +43 B (+0.25%)
packages/components/dist/index.js 18.4 kB +21 B (+0.11%)
packages/components/dist/style.css 7.92 kB +21 B (+0.27%)
packages/tokens/dist/index.es.js 3.07 kB +12 B (+0.39%)
packages/tokens/dist/index.js 3.11 kB +12 B (+0.39%)
packages/tokens/dist/themes.css 2.27 kB +29 B (+1.3%)
packages/vars/dist/index.es.js 2.66 kB +18 B (+0.68%)
packages/vars/dist/index.js 2.66 kB +19 B (+0.72%)
ℹ️ View Unchanged
Filename Size
apps/vscode/dist/client.js 111 kB
packages/box/dist/style.css 2.67 kB
packages/button/dist/index.es.js 1.89 kB
packages/button/dist/index.js 2.32 kB
packages/button/dist/style.css 3 kB
packages/core/dist/index.es.js 512 B
packages/core/dist/index.js 1.27 kB
packages/drawer/dist/index.es.js 1.76 kB
packages/drawer/dist/index.js 2.22 kB
packages/drawer/dist/style.css 497 B
packages/dropdown/dist/index.es.js 1.15 kB
packages/dropdown/dist/index.js 1.59 kB
packages/filter/dist/index.es.js 2.23 kB
packages/filter/dist/index.js 2.68 kB
packages/filter/dist/style.css 881 B
packages/focus-trap/dist/index.es.js 418 B
packages/focus-trap/dist/index.js 852 B
packages/form/dist/index.es.js 4.25 kB
packages/form/dist/index.js 4.73 kB
packages/form/dist/style.css 2.21 kB
packages/icons/dist/index.es.js 1.3 kB
packages/icons/dist/index.js 1.73 kB
packages/icons/dist/style.css 532 B
packages/menu/dist/index.es.js 3.69 kB
packages/menu/dist/index.js 4.16 kB
packages/menu/dist/style.css 872 B
packages/modal/dist/index.es.js 3.08 kB
packages/modal/dist/index.js 3.55 kB
packages/modal/dist/style.css 898 B
packages/navigation/dist/index.es.js 2.75 kB
packages/navigation/dist/index.js 3.21 kB
packages/navigation/dist/style.css 874 B
packages/overlay/dist/index.es.js 1.02 kB
packages/overlay/dist/index.js 1.42 kB
packages/popover/dist/index.es.js 3.01 kB
packages/popover/dist/index.js 3.43 kB
packages/popover/dist/style.css 529 B
packages/portal/dist/index.es.js 420 B
packages/portal/dist/index.js 835 B
packages/table/dist/index.es.js 1.01 kB
packages/table/dist/index.js 1.44 kB
packages/table/dist/style.css 700 B
packages/tokens/dist/fonts.css 183 B
packages/tokens/dist/index.css 1.47 kB
packages/tokens/dist/media-queries.css 113 B
packages/tooltip/dist/index.es.js 598 B
packages/tooltip/dist/index.js 1.02 kB
packages/tooltip/dist/style.css 337 B

compressed-size-action

Copy link
Contributor

@apucacao apucacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️

Copy link

changeset-bot bot commented Jul 18, 2025

🦋 Changeset detected

Latest commit: 85f0936

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@launchpad-ui/components Minor
@launchpad-ui/tokens Minor
launchpad-design-system Patch
@launchpad-ui/box Patch
@launchpad-ui/button Patch
@launchpad-ui/drawer Patch
@launchpad-ui/dropdown Patch
@launchpad-ui/filter Patch
@launchpad-ui/form Patch
@launchpad-ui/icons Patch
@launchpad-ui/menu Patch
@launchpad-ui/modal Patch
@launchpad-ui/navigation Patch
@launchpad-ui/popover Patch
@launchpad-ui/table Patch
@launchpad-ui/tooltip Patch
@launchpad-ui/vars Patch
@launchpad-ui/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OneHunnid
Copy link

LGTM!

@apucacao apucacao merged commit 77e938e into main Jul 21, 2025
14 checks passed
@apucacao apucacao deleted the zuzze/fix/tag-warning-variant-and-token branch July 21, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants