Skip to content

feat: Add hook support for the track series. #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

kinyoklion
Copy link
Member

@kinyoklion kinyoklion commented Apr 17, 2025

Adds support for the track series to the client-side hook implementation.

expect(logger.error).not.toHaveBeenCalled();
});

it('executes hook stages in the specified order', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was missing from the client-side implementation previously. Added it and extended it for track.

Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 19198 bytes
Size limit: 21000

Copy link
Contributor

github-actions bot commented Apr 17, 2025

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 20043 bytes
Size limit: 21000

Copy link
Contributor

github-actions bot commented Apr 17, 2025

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15481 bytes
Size limit: 20000

@kinyoklion kinyoklion marked this pull request as ready for review April 17, 2025 22:59
@kinyoklion kinyoklion requested a review from a team as a code owner April 17, 2025 22:59
@kinyoklion kinyoklion merged commit 1519cb9 into main Apr 22, 2025
25 checks passed
@kinyoklion kinyoklion deleted the rlamb/emsr-315/hook-track-support branch April 22, 2025 16:27
@github-actions github-actions bot mentioned this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants