Changes back to async flushes after the unload handler has completed #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-darkly
approved these changes
Jan 27, 2020
Merged
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Jan 27, 2020
fix goals query logic for Electron, also fix handling of invalid content type
|
We've released version 2.16.2 with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to have your opinion on this change. I have not confirmed if this solves my issue. However the test cases indicates that it does solve it.
Requirements
Related issues
Potential fix for #198
Describe the solution you've provided
This sets the syncFlush flag back to false after we have flushed any events that needed to be flushed during the beforeunload event.