Skip to content

fix(macros): slightly improve unsupported type error message #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dyc3
Copy link

@dyc3 dyc3 commented May 9, 2025

Does your PR solve an issue?

This PR makes a small improvement to the "unsupported type" error message to suggest a potential solution to the user.

I just spent a couple hours on an issue forgetting that type overrides exist and I wished that the message nudged me in that direction.
Perhaps the message could be made even more intelligent.

Is this a breaking change?

No. It's a minor DX improvement.

@abonander
Copy link
Collaborator

abonander commented May 12, 2025

I've significantly revised the wording as part of #3383:

There's some significant changes coupled in there, but if you'd like to backport the wording, I wouldn't be against it.

@dyc3
Copy link
Author

dyc3 commented May 12, 2025

Ah, so should I make this PR against that branch instead?

@abonander
Copy link
Collaborator

No, I meant that you could copy the wording changes I made in that PR to this one, since that's slated for 0.9.0.

Probably going to have one more patch release before 0.9.0 since we've accumulated a few regressions, so that part could be backported.

@dyc3
Copy link
Author

dyc3 commented May 13, 2025

Oh, ok. Yeah I can do that.

@dyc3
Copy link
Author

dyc3 commented May 14, 2025

This should be ready to go. Let me know if I should do more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants