Add flink-connector-jdbc-spnner #1
Closed
+2,424
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laughingman7743
force-pushed
the
jdbc_spanner_connector
branch
3 times, most recently
from
b4eefd9 to
bbaa0ea
Compare
laughingman7743
commented
Jan 14, 2025
| @@ -91,6 +91,8 @@ protected JdbcResultSetBuilder<Row> getResultSetBuilder() { | |||
| } else if (type.getConversionClass().equals(LocalDateTime.class)) { | |||
| ps.setTimestamp( | |||
| i + 1, Timestamp.valueOf(row.<LocalDateTime>getFieldAs(i))); | |||
| } else if (type.getConversionClass().equals(Float.class)) { | |||
There was a problem hiding this comment.
I added handling for the Float type because an error occurred.
com.google.cloud.spanner.jdbc.JdbcSqlExceptionFactory$JdbcSqlBatchUpdateException:
Value has type FLOAT64 which cannot be inserted into column float_col, which has type FLOAT [at 1:131]
...double_col, timestamp9_col) VALUES (@p1, @p2, @p3, @p4, @p5, @p6)
2974caf to
c6a2441
Compare
laughingman7743
force-pushed
the
jdbc_spanner_connector
branch
from
209fa32 to
4766a51
Compare
laughingman7743
commented
Feb 9, 2025
| @@ -120,7 +122,7 @@ public int[] getTableTypes() { | |||
| .toArray(); | |||
| } | |||
|
|
|||
| public Schema getTableSchema() { | |||
| public Schema getTableSchema(String pkConstraintName) { | |||
There was a problem hiding this comment.
In the case of Spanner, the contract name of the primary key is different, so it is possible to specify the contract name of the primary key.
laughingman7743
commented
Feb 9, 2025
Comment on lines
-579
to
-587
| /** | ||
| * URL has to be without database, like "jdbc:dialect://localhost:1234/" or | ||
| * "jdbc:dialect://localhost:1234" rather than "jdbc:dialect://localhost:1234/db". | ||
| */ | ||
| protected static void validateJdbcUrl(String url) { | ||
| String[] parts = url.trim().split("\\/+"); | ||
|
|
||
| checkArgument(parts.length == 2); | ||
| } |
There was a problem hiding this comment.
In the case of Spanner, the URL is as follows, so I have deleted this validation.
jdbc:cloudspanner://hostname/projects/gcp_project_id/instances/instance_id/databases/database_id
laughingman7743
commented
Feb 9, 2025
Comment on lines
-133
to
-138
| this.connectionProperties = Preconditions.checkNotNull(connectionProperties); | ||
| checkArgument( | ||
| !StringUtils.isNullOrWhitespaceOnly(connectionProperties.getProperty(USER_KEY))); | ||
| checkArgument( | ||
| !StringUtils.isNullOrWhitespaceOnly( | ||
| connectionProperties.getProperty(PASSWORD_KEY))); |
There was a problem hiding this comment.
Spanner does not use password authentication.
laughingman7743
commented
Feb 9, 2025
|
|
||
| /** Test for {@link AbstractJdbcCatalog}. */ | ||
| class AbstractJdbcCatalogTest { |
There was a problem hiding this comment.
This class is no longer needed because URL validation has been removed.
laughingman7743
force-pushed
the
jdbc_spanner_connector
branch
from
4766a51 to
9d4b764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.