fix(crowdloan): normalize creator checks for proxy actors#904
Closed
bitloi wants to merge 1 commit intolatent-to:stagingfrom
Closed
fix(crowdloan): normalize creator checks for proxy actors#904bitloi wants to merge 1 commit intolatent-to:stagingfrom
bitloi wants to merge 1 commit intolatent-to:stagingfrom
Conversation
bitloi
force-pushed
the
fix/issue-liquidity-remove-all
branch
from
183df0e to
c50c3a8
Compare
bitloi
changed the title
Contributor
Author
|
I will keep this PR open for now. |
Contributor
|
Superceded by #908 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the effective actor (
proxyif set, otherwise wallet coldkey) for creator checks in crowdloanfinalize,update, anddissolve.Adds regression tests that cover: