Conversation
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
Pull request overview
This PR adds ARM64 platform support to the Docker build workflow and introduces a new UI service to the Docker Compose configuration.
Changes:
- Modified release workflow to build Docker images for both AMD64 and ARM64 platforms
- Added bulwarkauthadmin-ui service to docker-compose.yml with health checks and dependency configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | Extends Docker build platforms from linux/amd64 only to include linux/arm64 for multiplatform image support |
| docker-compose.yml | Introduces new bulwarkauthadmin-ui service with port mappings, health checks, and service dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bulwarkauthadmin-ui: | ||
| image: ghcr.io/latebit-io/bulwarkauthadmin-ui:latest | ||
| container_name: bulwarkauthadmin_ui_container | ||
| ports: | ||
| - 3000:80 | ||
| depends_on: | ||
| bulwarkauthadmin: | ||
| condition: service_healthy | ||
| healthcheck: | ||
| test: ['CMD', 'wget', '-q', '--spider', 'http://localhost:80'] | ||
| interval: 5s | ||
| timeout: 5s | ||
| retries: 3 | ||
| restart: on-failure |
There was a problem hiding this comment.
The addition of the bulwarkauthadmin-ui service is not mentioned in the PR title or description, which only references "allow multiplatform image". This creates confusion about the scope of this PR. Additionally, this service uses a different networking approach than the other bulwark services (bulwarkauth and bulwarkauthadmin both use network_mode: 'host' on lines 43 and 61), but bulwarkauthadmin-ui uses bridge networking with port mapping. This inconsistency could cause connectivity issues between services, especially given the depends_on relationship with bulwarkauthadmin which uses host networking.
| bulwarkauthadmin-ui: | ||
| image: ghcr.io/latebit-io/bulwarkauthadmin-ui:latest | ||
| container_name: bulwarkauthadmin_ui_container | ||
| ports: | ||
| - 3000:80 | ||
| depends_on: | ||
| bulwarkauthadmin: | ||
| condition: service_healthy | ||
| healthcheck: | ||
| test: ['CMD', 'wget', '-q', '--spider', 'http://localhost:80'] | ||
| interval: 5s | ||
| timeout: 5s | ||
| retries: 3 | ||
| restart: on-failure |
There was a problem hiding this comment.
The bulwarkauthadmin-ui service is missing from the CI workflow logs sections (lines 119-124 in .github/workflows/ci.yml). When this service fails, debugging will be difficult because its logs won't be captured. Consider adding a log output for this service in the CI workflow's failure handling section.
No description provided.